Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java

Issue 2727873002: Implement lazy initialization for VrShellDelegate (Closed)
Patch Set: Fix FindBugs errors - neat! Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
index 20f8aec7038ddeb6a32dec1ef096aee497e56199..e73a1f340cc6acc3ff6af94bdc92e8debfe43600 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
@@ -24,7 +24,6 @@ import org.chromium.ui.base.WindowAndroid;
* use it, or API calls begin to silently fail.
*/
public class VrDaydreamApiImpl implements VrDaydreamApi {
- private static final String TAG = "VrDaydreamApiImpl";
private final Context mContext;
public VrDaydreamApiImpl(Context context) {
@@ -70,10 +69,10 @@ public class VrDaydreamApiImpl implements VrDaydreamApi {
@Override
public boolean exitFromVr(int requestCode, final Intent intent) {
- DaydreamApi daydreamApi = DaydreamApi.create(mContext);
- if (daydreamApi == null) return false;
Activity activity = WindowAndroid.activityFromContext(mContext);
Assert.assertNotNull(activity);
+ DaydreamApi daydreamApi = DaydreamApi.create(activity);
+ if (daydreamApi == null) return false;
daydreamApi.exitFromVr(activity, requestCode, intent);
daydreamApi.close();
return true;

Powered by Google App Engine
This is Rietveld 408576698