Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutQuote.h

Issue 2727853002: [css-display] Support display: contents pseudo-elements.
Patch Set: Add missing nullcheck (whoops). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutQuote.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutQuote.h b/third_party/WebKit/Source/core/layout/LayoutQuote.h
index 3b460372d2511f59858c4d495865caa4dcaa1350..a013482c503fb2fce506381725cef3dc72eef702 100644
--- a/third_party/WebKit/Source/core/layout/LayoutQuote.h
+++ b/third_party/WebKit/Source/core/layout/LayoutQuote.h
@@ -27,8 +27,8 @@
namespace blink {
-class Document;
class LayoutTextFragment;
+class PseudoElement;
// LayoutQuote is the layout object associated with generated quotes
// ("content: open-quote | close-quote | no-open-quote | no-close-quote").
@@ -40,7 +40,7 @@ class LayoutTextFragment;
// and |m_previous| below.
class LayoutQuote final : public LayoutInline {
public:
- LayoutQuote(Document*, const QuoteType);
+ LayoutQuote(PseudoElement&, const QuoteType);
~LayoutQuote() override;
void attachQuote();
@@ -88,6 +88,14 @@ class LayoutQuote final : public LayoutInline {
// up-to-date linked list positions).
bool m_attached;
+ // The pseudo-element that owns us.
+ //
+ // TODO(ecobos@igalia.com): This is also in m_node, should we make that
+ // protected instead of private? Seems easy to misuse.
+ //
+ // Livedness is the same as m_node, so this is safe.
rune 2017/03/13 10:36:00 "Lifetime is the same as for LayoutObject::m_node"
+ UntracedMember<PseudoElement> m_owningPseudo;
+
// Cached text for this quote.
String m_text;
};

Powered by Google App Engine
This is Rietveld 408576698