third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h - Issue 2727803004: Replace string by enum in WebParsedFeaturePolicyDeclaration#feature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h

Issue 2727803004: Replace string by enum in WebParsedFeaturePolicyDeclaration#feature (Closed)

Patch Set: Codereview: nit -- add comments to introduce features Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h

diff --git a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h

index 52e1a9b03497b1fea19860ad61b762937527ce95..916b780bfe681cca1ac046a7bc08f69f0708b709 100644

--- a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h

+++ b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h

@@ -22,9 +22,8 @@ PLATFORM_EXPORT WebFeaturePolicyFeature

getWebFeaturePolicyFeature(const String& feature);

// Converts a JSON feature policy string into a vector of whitelists, one for

-// each feature specified. Unrecognized features are parsed and included

-// but will be filtered out when the policy is constructed. If |messages| is

-// not null, then any errors in the input will cause an error message to be

+// each feature specified. Unrecognized features are filtered out. If |messages|

+// is not null, then any errors in the input will cause an error message to be

// appended to it.

PLATFORM_EXPORT WebParsedFeaturePolicy

parseFeaturePolicy(const String& policy,