content/child/feature_policy/feature_policy_platform.cc - Issue 2727803004: Replace string by enum in WebParsedFeaturePolicyDeclaration#feature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/feature_policy/feature_policy_platform.cc

Issue 2727803004: Replace string by enum in WebParsedFeaturePolicyDeclaration#feature (Closed)

Patch Set: Codereview: nit -- add comments to introduce features Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/feature_policy/feature_policy_platform.cc

diff --git a/content/child/feature_policy/feature_policy_platform.cc b/content/child/feature_policy/feature_policy_platform.cc

index 1a1b81d13d501708b52c755fcbb5cce90449df6e..3b2b062ecf17b4e0ffeea4d9b3927e5897651228 100644

--- a/content/child/feature_policy/feature_policy_platform.cc

+++ b/content/child/feature_policy/feature_policy_platform.cc

@@ -12,7 +12,7 @@ ParsedFeaturePolicyHeader FeaturePolicyHeaderFromWeb(

for (const blink::WebParsedFeaturePolicyDeclaration& web_declaration :

web_feature_policy_header) {

ParsedFeaturePolicyDeclaration declaration;

- declaration.feature_name = web_declaration.featureName.utf8();

+ declaration.feature = web_declaration.feature;

declaration.matches_all_origins = web_declaration.matchesAllOrigins;

for (const blink::WebSecurityOrigin& web_origin : web_declaration.origins)

declaration.origins.push_back(web_origin);

@@ -27,8 +27,7 @@ blink::WebParsedFeaturePolicy FeaturePolicyHeaderToWeb(

for (const ParsedFeaturePolicyDeclaration& declaration :

feature_policy_header) {

blink::WebParsedFeaturePolicyDeclaration web_declaration;

- web_declaration.featureName =

- blink::WebString::fromUTF8(declaration.feature_name);

+ web_declaration.feature = declaration.feature;

web_declaration.matchesAllOrigins = declaration.matches_all_origins;

std::vector<blink::WebSecurityOrigin> web_origins;

for (const url::Origin& origin : declaration.origins)