Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2727803004: Replace string by enum in WebParsedFeaturePolicyDeclaration#feature (Closed)
Patch Set: Set upstream Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 2a89fe80209232bc83a4006d07f4be81294b499e..dd83b76683499c3cfcb5a5af3abe448c052ef945 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -678,10 +678,10 @@ class SitePerProcessFeaturePolicyBrowserTest
"FeaturePolicy");
}
- ParsedFeaturePolicyHeader CreateFPHeader(const std::string& feature_name,
+ ParsedFeaturePolicyHeader CreateFPHeader(const std::string&.feature,
iclelland 2017/03/06 13:55:59 Looks like there are some extra "." characters in
const std::vector<GURL>& origins) {
ParsedFeaturePolicyHeader result(1);
- result[0].feature_name = feature_name;
+ result[0].feature =.feature;
iclelland 2017/03/06 13:55:59 Here too
result[0].matches_all_origins = false;
DCHECK(!origins.empty());
for (const GURL& origin : origins)
@@ -690,9 +690,9 @@ class SitePerProcessFeaturePolicyBrowserTest
}
ParsedFeaturePolicyHeader CreateFPHeaderMatchesAll(
- const std::string& feature_name) {
+ const std::string&.feature) {
iclelland 2017/03/06 13:55:59 And here
ParsedFeaturePolicyHeader result(1);
- result[0].feature_name = feature_name;
+ result[0].feature =.feature;
iclelland 2017/03/06 13:55:59 And here.
result[0].matches_all_origins = true;
return result;
}
@@ -700,10 +700,8 @@ class SitePerProcessFeaturePolicyBrowserTest
bool operator==(const ParsedFeaturePolicyDeclaration& first,
const ParsedFeaturePolicyDeclaration& second) {
- return std::tie(first.feature_name, first.matches_all_origins,
- first.origins) == std::tie(second.feature_name,
- second.matches_all_origins,
- second.origins);
+ return std::tie(first.feature, first.matches_all_origins, first.origins) ==
+ std::tie(second.feature, second.matches_all_origins, second.origins);
}
double GetFrameDeviceScaleFactor(const ToRenderFrameHost& adapter) {

Powered by Google App Engine
This is Rietveld 408576698