third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp - Issue 2727803004: Replace string by enum in WebParsedFeaturePolicyDeclaration#feature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp

Issue 2727803004: Replace string by enum in WebParsedFeaturePolicyDeclaration#feature (Closed)

Patch Set: Filter out unrecognized features in parseFeaturePolicy (earlier) instead of setHeaderPolicy Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/feature_policy/feature_policy.cc ('K') | « third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h ('k') | third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp

diff --git a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp

index 9b8a0578467160ba1737dfa649a9bfbbe79b4064..f6cc6b7fa9776b6cb1587e9fa85aad20ee688457 100644

--- a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp

+++ b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp

@@ -71,7 +71,9 @@ WebParsedFeaturePolicyHeader parseFeaturePolicy(const String& policy,

for (size_t j = 0; j < item->size(); ++j) {

JSONObject::Entry entry = item->at(j);

- String featureName = entry.first;

+ WebFeaturePolicyFeature feature = getWebFeaturePolicyFeature(entry.first);

+ if (feature == WebFeaturePolicyFeature::NotFound)

+ continue;

JSONArray* targets = JSONArray::cast(entry.second);

if (!targets) {

if (messages)

@@ -80,7 +82,7 @@ WebParsedFeaturePolicyHeader parseFeaturePolicy(const String& policy,

}

WebParsedFeaturePolicyDeclaration whitelist;

- whitelist.featureName = featureName;

+ whitelist.feature = feature;

Vector<WebSecurityOrigin> origins;

String targetString;

for (size_t j = 0; j < targets->size(); ++j) {