Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerError.cpp

Issue 27278002: Add an Error class for ServiceWorkers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address review nits Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerError.cpp
diff --git a/Source/core/html/HTMLMediaSource.cpp b/Source/modules/serviceworkers/ServiceWorkerError.cpp
similarity index 84%
copy from Source/core/html/HTMLMediaSource.cpp
copy to Source/modules/serviceworkers/ServiceWorkerError.cpp
index 7221cfeaf34ed4e40fd174029a3fa66a6d8dd411..9e927a0d6cad84cf21eaa8911ab1c21031ec0e72 100644
--- a/Source/core/html/HTMLMediaSource.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerError.cpp
@@ -29,16 +29,19 @@
*/
#include "config.h"
-#include "core/html/HTMLMediaSource.h"
+#include "ServiceWorkerError.h"
+using WebKit::WebServiceWorkerError;
abarth-chromium 2013/10/25 15:37:16 Why do you have this using directive and then use
alecflett 2013/10/25 23:05:33 Done. (oops, oversight)
namespace WebCore {
-URLRegistry* HTMLMediaSource::s_registry = 0;
-
-void HTMLMediaSource::setRegistry(URLRegistry* registry)
+String ServiceWorkerError::getErrorString(WebKit::WebServiceWorkerError::ErrorType type)
{
- ASSERT(!s_registry);
- s_registry = registry;
+ switch (type) {
+ case WebServiceWorkerError::DisabledError:
+ return "DisabledError";
+ default:
+ ASSERT_NOT_REACHED();
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698