Source/modules/serviceworkers/NavigatorServiceWorker.cpp - Issue 27278002: Add an Error class for ServiceWorkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/NavigatorServiceWorker.cpp

Issue 27278002: Add an Error class for ServiceWorkers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix string threadsafety, ownership model Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | Source/modules/serviceworkers/ServiceWorkerError.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/NavigatorServiceWorker.cpp

diff --git a/Source/modules/serviceworkers/NavigatorServiceWorker.cpp b/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

index df87469d85aae31624972f945f070ae80e969f90..895b2e68efa2ae270d2fdcc092ab5b262a69ea80 100644

--- a/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

+++ b/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

@@ -32,6 +32,7 @@

#include "RuntimeEnabledFeatures.h"

#include "V8ServiceWorker.h"

+#include "bindings/V8DOMError.h"

#include "bindings/v8/CallbackPromiseAdapter.h"

#include "bindings/v8/ScriptPromiseResolver.h"

#include "core/dom/Document.h"

@@ -43,6 +44,7 @@

#include "core/loader/FrameLoaderClient.h"

#include "core/workers/SharedWorker.h"

#include "modules/serviceworkers/ServiceWorker.h"

+#include "modules/serviceworkers/ServiceWorkerError.h"

#include "public/platform/WebServiceWorkerProvider.h"

#include "public/platform/WebServiceWorkerProviderClient.h"

#include "public/platform/WebString.h"

@@ -122,7 +124,7 @@ ScriptPromise NavigatorServiceWorker::registerServiceWorker(ExecutionContext* ex

ScriptPromise promise = ScriptPromise::createPending(executionContext);

RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(promise, executionContext);

- ensureProvider()->registerServiceWorker(patternURL, scriptURL, new CallbackPromiseAdapter<ServiceWorker, ServiceWorker>(resolver, executionContext));

+ ensureProvider()->registerServiceWorker(patternURL, scriptURL, new CallbackPromiseAdapter<ServiceWorker, ServiceWorkerError>(resolver, executionContext));

return promise;

}

@@ -150,7 +152,7 @@ ScriptPromise NavigatorServiceWorker::unregisterServiceWorker(ExecutionContext*

ScriptPromise promise = ScriptPromise::createPending(executionContext);

RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(promise, executionContext);

- ensureProvider()->unregisterServiceWorker(patternURL, new CallbackPromiseAdapter<ServiceWorker, ServiceWorker>(resolver, executionContext));

+ ensureProvider()->unregisterServiceWorker(patternURL, new CallbackPromiseAdapter<ServiceWorker, ServiceWorkerError>(resolver, executionContext));

return promise;

}

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | Source/modules/serviceworkers/ServiceWorkerError.h » ('J')