Add an Error class for ServiceWorkers

Source/modules/serviceworkers/ServiceWorkerError.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef Composition_h
-#define Composition_h
+#ifndef ServiceWorkerError_h
+#define ServiceWorkerError_h
 
-#include "bindings/v8/ScriptWrappable.h"
+#include "core/dom/DOMError.h"
+#include "public/platform/WebServiceWorkerError.h"
 #include "wtf/PassOwnPtr.h"
-#include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
-class InputMethodContext;
+class ServiceWorkerError {
+public:
+    // For CallbackPromiseAdapter
+    typedef WebKit::WebServiceWorkerError WebType;
+    static PassRefPtr<DOMError> from(WebType* webErrorRaw)
+    {
+        OwnPtr<WebType> webError = adoptPtr(webErrorRaw);
+        RefPtr<DOMError> error = DOMError::create(getErrorString(webError->errorType), webError->message);
+        return error;

[abarth-chromium, 2013/10/25 15:37:16]

error.release()

[alecflett, 2013/10/25 23:05:33]

Done. (I was actually surprised to see the non-release() even compiled, now that
I think about it - would this have leaked, or does the explicit release just
avoid refcount churn?)

+    }
 
-class Composition : public ScriptWrappable {
-public:
-    static PassOwnPtr<Composition> create(InputMethodContext*);
-    ~Composition();
-
-    void ref();
-    void deref();
-
-    String text() const;
-    int selectionStart() const;
-    int selectionEnd() const;
-    const Vector<unsigned>& getSegments() const;
+    static String getErrorString(WebKit::WebServiceWorkerError::ErrorType);

[abarth-chromium, 2013/10/25 15:37:16]

getErrorString -> errorString

Can this function be private?

[alecflett, 2013/10/25 23:05:33]

Done.

 
 private:
-    explicit Composition(InputMethodContext*);
-
-    InputMethodContext* m_inputMethodContext;
+    WTF_MAKE_NONCOPYABLE(ServiceWorkerError);
+    ServiceWorkerError() WTF_DELETED_FUNCTION;
 };
 
 } // namespace WebCore
 
-#endif // Composition_h
+#endif // ServiceWorkerError_h