LayoutTests/http/tests/serviceworker/registration.html - Issue 27278002: Add an Error class for ServiceWorkers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/registration.html

Issue 27278002: Add an Error class for ServiceWorkers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address review nits Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="/js-test-resources/js-test-pre.js"></script>

	4 </head>

	5 <body>

	6 <script>

	7 description("Tests if ServiceWorker registration is working")

	8

	9 function test_registerBasics() {
	michaeln 2013/10/24 23:26:55 I'd suggest we not add this particular positive te I'd suggest we not add this particular positive test until we're farther along. The other error condition tests looks good for now since we have real code to actually detect those error conditions. Might want to make this registration_error_conditions.html? In general, I'd vote to rely more heavily on unit test initially than on layout tests which quickly turn into full blown system integration tests. We just have no system yet to test.
	10 debug("Registering normal pattern");

	11 return navigator.registerServiceWorker("/*", "serviceworker.js").then(

	12 function(worker) {

	13 debug("ServiceWorker registered.");

	14 });

	15 }

	16 function test_registerPatternOutsideDomain() {

	17 debug("Registering pattern outside domain");

	18 return navigator.registerServiceWorker("http://foo.com/*", "servicewor ker.js")

	19 .catch(function(e) {

	20 regError = e;

	21 shouldBe("'SecurityError'", "regError.name");

	22 });

	23 }

	24 function test_registerScriptOutsideDomain() {

	25 debug("Registering pattern outside domain");

	26 return navigator.registerServiceWorker("/*", "http://foo.com/servicewo rker.js")

	27 .catch(function(e) {

	28 regError = e;

	29 shouldBe("'SecurityError'", "regError.name");

	30 });

	31 }

	32 var jsTestIsAsync = true;

	33 test_registerBasics()

	34 .then(test_registerPatternOutsideDomain)

	35 .then(test_registerScriptOutsideDomain)

	36 .then(finishJSTest, function(e) {

	37 testFailed("Tests failed, exited with error:" + e.name + ": " + e.mess age);

	38 finishJSTest();

	39 });

	40 </script>

	41 <script src="/js-test-resources/js-test-post.js"></script>

	42 </body>

	43 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/registration-expected.txt » ('j') | Source/modules/serviceworkers/NavigatorServiceWorker.cpp » ('J')