Parse InstanceCreationExpression with Fasta.

Parse InstanceCreationExpression with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/86b5a088ad4007f01265caa34ff294f858d068b3

[Paul Berry, 2017-03-01 20:57:54]

lgtm

[scheglov, 2017-03-01 21:04:54]

Description was changed from

==========
Parse InstanceCreationExpression with Fasta.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Parse InstanceCreationExpression with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/86b5a088ad4007f01265caa34ff294f858d068b3
==========

[scheglov, 2017-03-01 21:04:56]

Committed patchset #1 (id:1) manually as
86b5a088ad4007f01265caa34ff294f858d068b3 (presubmit successful).

[ahe, 2017-03-02 07:23:49]

lgtm

Great idea!

https://codereview.chromium.org/2727753002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2727753002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:845: void
handleNoConstructorReferenceContinuationAfterTypeArguments(Token token) {
I'd like to see documentation on this method, and possibly a shorter name.

[scheglov, 2017-03-02 16:26:27]

https://codereview.chromium.org/2727753002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2727753002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:845: void
handleNoConstructorReferenceContinuationAfterTypeArguments(Token token) {
On 2017/03/02 07:23:49, ahe wrote:
> I'd like to see documentation on this method, and possibly a shorter name.

I thought it is the established order this is codebase to don't write
documentation and leave it to the reader to guess what is used for what.

As for name, I used the same name as
IdentifierContext.constructorReferenceContinuationAfterTypeArguments, also for
consistency.

[ahe, 2017-03-02 17:23:18]

https://codereview.chromium.org/2727753002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2727753002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:845: void
handleNoConstructorReferenceContinuationAfterTypeArguments(Token token) {
On 2017/03/02 16:26:27, scheglov wrote:
> On 2017/03/02 07:23:49, ahe wrote:
> > I'd like to see documentation on this method, and possibly a shorter name.
> 
> I thought it is the established order this is codebase to don't write
> documentation and leave it to the reader to guess what is used for what.

Well, I'm trying to atone for my past mistakes.

I was thinking something like:

Handle's this case:

    a.b<t>

Where there's no identifier after the type arguments.

Is that correctly understood?

> As for name, I used the same name as
> IdentifierContext.constructorReferenceContinuationAfterTypeArguments, also for
> consistency.

OK.