Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: mojo/public/cpp/bindings/associated_binding.h

Issue 2727733004: [IndexedDB] Closing mojo connections when renderer quits (Closed)
Patch Set: comments, still figuring out how to test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/associated_binding.h
diff --git a/mojo/public/cpp/bindings/associated_binding.h b/mojo/public/cpp/bindings/associated_binding.h
index 59411666f5aca80a6e05953070ccb821ef2040e3..177af29ff590236bda6cea6ff8ed8c1d68823db1 100644
--- a/mojo/public/cpp/bindings/associated_binding.h
+++ b/mojo/public/cpp/bindings/associated_binding.h
@@ -98,7 +98,9 @@ class AssociatedBinding : public AssociatedBindingBase {
// implementation |impl|. It may be completed with a subsequent call to the
// |Bind| method. Does not take ownership of |impl|, which must outlive this
cmumford 2017/03/07 20:24:23 Doesn't moving |impl| mean that we're taking owner
dmurph 2017/03/09 20:44:15 Done.
// object.
- explicit AssociatedBinding(ImplPointerType impl) { stub_.set_sink(impl); }
+ explicit AssociatedBinding(ImplPointerType impl) {
+ stub_.set_sink(std::move(impl));
+ }
// Constructs a completed associated binding of |impl|. The output |ptr_info|
// should be sent by another interface. |impl| must outlive this object.

Powered by Google App Engine
This is Rietveld 408576698