content/browser/renderer_host/render_process_host_impl.cc - Issue 2727733004: [IndexedDB] Closing mojo connections when renderer quits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2727733004: [IndexedDB] Closing mojo connections when renderer quits (Closed)

Patch Set: No more raw pointers where we're not guarenteed lifetime Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index b1a238db5ab529c4be1d6324ca1e393f357ce979..df0d071812f8786f81d55af1f2d6ac0c03d5f251 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -1200,7 +1200,9 @@ void RenderProcessHostImpl::RegisterMojoInterfaces() {

service_manager::mojom::kServiceManager_ConnectorSpec);

channel_->AddAssociatedInterfaceForIOThread(

- base::Bind(&IndexedDBDispatcherHost::AddBinding, indexed_db_factory_));

+ base::Bind(&IndexedDBDispatcherHost::AddBinding,

+ base::Unretained(indexed_db_factory_.get())));

+ AddObserver(indexed_db_factory_.get());

#if defined(OS_ANDROID)

AddUIThreadInterface(registry.get(),