[IndexedDB] Closing mojo connections when renderer quits

content/browser/indexed_db/indexed_db_callbacks.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_
 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 22 matching lines @@
 struct IndexedDBValue;
 
 class CONTENT_EXPORT IndexedDBCallbacks
     : public base::RefCounted<IndexedDBCallbacks> {
  public:
   // Destructively converts an IndexedDBValue to a Mojo Value.
   static ::indexed_db::mojom::ValuePtr ConvertAndEraseValue(
       IndexedDBValue* value);
 
   IndexedDBCallbacks(
-      scoped_refptr<IndexedDBDispatcherHost> dispatcher_host,
+      IndexedDBDispatcherHost* dispatcher_host,
       const url::Origin& origin,
       ::indexed_db::mojom::CallbacksAssociatedPtrInfo callbacks_info);
 
   virtual void OnError(const IndexedDBDatabaseError& error);
 
   // IndexedDBFactory::GetDatabaseNames
   virtual void OnSuccess(const std::vector<base::string16>& string);
 
   // IndexedDBFactory::Open / DeleteDatabase
   virtual void OnBlocked(int64_t existing_version);
@@ skipping 46 matching lines @@
 
  protected:
   virtual ~IndexedDBCallbacks();
 
  private:
   friend class base::RefCounted<IndexedDBCallbacks>;
 
   class IOThreadHelper;
 
   // Originally from IndexedDBCallbacks:
-  scoped_refptr<IndexedDBDispatcherHost> dispatcher_host_;
+  IndexedDBDispatcherHost* dispatcher_host_;

[Reilly Grant (use Gerrit), 2017/03/10 00:11:22]

I'm less confident that this is safe unless we can be sure that destruction of
an IndexedDBConnection guarantees that this will be freed.

[dmurph, 2017/03/10 23:40:26]

Removed. All raw pointers are removed except for ones we can prove lifetime
ownership.

 
   // IndexedDBDatabase callbacks ------------------------
   url::Origin origin_;
   bool database_sent_ = false;
 
   // Used to assert that OnSuccess is only called if there was no data loss.
   blink::WebIDBDataLoss data_loss_;
 
   // The "blocked" event should be sent at most once per request.
   bool sent_blocked_;
   base::TimeTicks connection_open_start_time_;
 
   std::unique_ptr<IOThreadHelper, BrowserThread::DeleteOnIOThread> io_helper_;
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(IndexedDBCallbacks);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_