Update FWMP in TPM

chromeos/dbus/cryptohome_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/cryptohome_client.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/bind.h"
@@ skipping 902 matching lines @@
 
   void FlushAndSignBootAttributes(
       const cryptohome::FlushAndSignBootAttributesRequest& request,
       const ProtobufMethodCallback& callback) override {
     const char* method_name = cryptohome::kCryptohomeFlushAndSignBootAttributes;
     dbus::MethodCall method_call(cryptohome::kCryptohomeInterface, method_name);
 
     dbus::MessageWriter writer(&method_call);
     writer.AppendProtoAsArrayOfBytes(request);
 
+    proxy_->CallMethod(&method_call, kTpmDBusTimeoutMs,
+                       base::Bind(&CryptohomeClientImpl::OnBaseReplyMethod,
+                                  weak_ptr_factory_.GetWeakPtr(), callback));
+  }
+
+  void AsyncTpmUpdateFirmwareManagementParameters(
+      const std::string& method_name,
+      const google::protobuf::MessageLite& request,
+      const ProtobufMethodCallback& callback) override {
+    dbus::MethodCall method_call(cryptohome::kCryptohomeInterface, method_name);

[Daniel Erat, 2017/03/06 21:18:26]

it looks like a bunch of these methods are all copy-and-pasted versions of each
other with different method names. would you mind moving this to an internal
helper method that takes a method name, MessageLite, and callback so that there
isn't so much duplication?

[igorcov, 2017/03/09 12:22:57]

Done, thanks for suggestion.

+
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendProtoAsArrayOfBytes(request);
+
     proxy_->CallMethod(&method_call,
                        kTpmDBusTimeoutMs ,
                        base::Bind(&CryptohomeClientImpl::OnBaseReplyMethod,
                                   weak_ptr_factory_.GetWeakPtr(),
                                   callback));
   }
 
  protected:
   void Init(dbus::Bus* bus) override {
     proxy_ = bus->GetObjectProxy(
@@ skipping 289 matching lines @@
   return new CryptohomeClientImpl();
 }
 
 // static
 std::string CryptohomeClient::GetStubSanitizedUsername(
     const cryptohome::Identification& cryptohome_id) {
   return cryptohome_id.id() + kUserIdStubHashSuffix;
 }
 
 }  // namespace chromeos