Better spellcheck_test

third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 // This file provides
 // |spellcheck_test(sample, tester, expectedText, opt_title)| asynchronous test
 // to W3C test harness for easier writing of spellchecker test cases.
 //
@@ skipping 257 matching lines @@
    */
   serializeInternal(node) {
     if (isElement(node))
       return this.handleElementNode(node);
     if (isCharacterData(node))
       return this.handleCharacterData(node);
     throw new Error(`Unexpected node ${node}`);
   }
 }
 
+/**
+ * @param {!Document} document
+ * @return {boolean}
+ */
+function hasPendingSpellCheckRequest(document) {
+  return internals.lastSpellCheckRequestSequence(document) !==
+      internals.lastSpellCheckProcessedSequence(document);
+}
+
 /** @type {string} */
 const kTitle = 'title';
 /** @type {string} */
 const kCallback = 'callback';
 /** @type {string} */
 const kIsSpellcheckTest = 'isSpellcheckTest';
 
-/**
- * @param {!Test} testObject
- * @param {!Sample} sample
- * @param {string} expectedText
- * @param {number} remainingRetry
- * @param {number} retryInterval
- */
-function verifyMarkers(
-    testObject, sample, expectedText, remainingRetry, retryInterval) {
-  assert_not_equals(
-      window.internals, undefined,
-      'window.internals is required for running automated spellcheck tests.');
-
-  /** @type {!MarkerSerializer} */
-  const serializer = new MarkerSerializer({
-    spelling: '#',
-    grammar: '~'});
-
-  try {
-    assert_equals(serializer.serialize(sample.document), expectedText);
-    testObject.done();
-  } catch (error) {
-    if (remainingRetry <= 0)
-      throw error;
-
-    // Force invoking idle time spellchecker in case it has not been run yet.
-    if (window.testRunner)
-      window.testRunner.runIdleTasks(() => {});
-
-    // TODO(xiaochengh): We should make SpellCheckRequester::didCheck trigger
-    // something in JavaScript (e.g., a |Promise|), so that we can actively
-    // know the completion of spellchecking instead of passively waiting for
-    // markers to appear or disappear.
-    testObject.step_timeout(
-        () => verifyMarkers(testObject, sample, expectedText,
-                            remainingRetry - 1, retryInterval),
-        retryInterval);
-  }
-}
-
 // Spellchecker gets triggered not only by text and selection change, but also
 // by focus change. For example, misspelling markers in <INPUT> disappear when
 // the window loses focus, even though the selection does not change.
 // Therefore, we disallow spellcheck tests from running simultaneously to
 // prevent interference among them. If we call spellcheck_test while another
 // test is running, the new test will be added into testQueue waiting for the
 // completion of the previous test.
 
 /** @type {boolean} */
 var spellcheckTestRunning = false;
 /** @type {!Array<!Object>} */
 const testQueue = [];
 
+/** @type {?Function} */
+var verificationForCurrentTest = null;

[yosin_UTC9, 2017/03/03 04:44:59]

nit: s/var/let/

[Xiaocheng, 2017/03/03 18:56:41]

Done.

+
 /**
  * @param {!Test} testObject
  * @param {!Sample|string} input
  * @param {function(!Document)|string} tester
  * @param {string} expectedText
  */
 function invokeSpellcheckTest(testObject, input, tester, expectedText) {
   spellcheckTestRunning = true;
 
   testObject.step(() => {
     // TODO(xiaochengh): Merge the following part with |assert_selection|.
     /** @type {!Sample} */
     const sample = typeof(input) === 'string' ? new Sample(input) : input;
     testObject.sample = sample;
 
     if (typeof(tester) === 'function') {
       tester.call(window, sample.document);
     } else if (typeof(tester) === 'string') {
       const strings = tester.split(/ (.+)/);
       sample.document.execCommand(strings[0], false, strings[1]);
     } else {
       assert_unreached(`Invalid tester: ${tester}`);
     }
 
-    /** @type {number} */
-    const kMaxRetry = 10;
-    /** @type {number} */
-    const kRetryInterval = 50;
+    assert_not_equals(
+        window.testRunner, undefined,
+        'window.testRunner is required for automated spellcheck tests.');
+    assert_not_equals(
+        window.internals, undefined,
+        'window.internals is required for automated spellcheck tests.');
 
-    // TODO(xiaochengh): We should make SpellCheckRequester::didCheck trigger
-    // something in JavaScript (e.g., a |Promise|), so that we can actively know
-    // the completion of spellchecking instead of passively waiting for markers
-    // to appear or disappear.
-    testObject.step_timeout(
-        () => verifyMarkers(testObject, sample, expectedText,
-                            kMaxRetry, kRetryInterval),
-        kRetryInterval);
+    assert_equals(
+        verificationForCurrentTest, null,
+        'Internal error: previous test not verified yet');
+
+    verificationForCurrentTest = () => {
+      if (hasPendingSpellCheckRequest(sample.document))
+        return;
+
+      testObject.step(() => {
+        /** @type {!MarkerSerializer} */
+        const serializer = new MarkerSerializer({
+          spelling: '#',
+          grammar: '~'});
+
+        assert_equals(serializer.serialize(sample.document), expectedText);
+        testObject.done();
+      });
+    };
+
+    if (internals.idleTimeSpellCheckerState !== undefined) {
+      if (internals.idleTimeSpellCheckerState(sample.document) === 'hot-mode-requested')

[yosin_UTC9, 2017/03/03 04:44:59]

nit: We can use just one if-statement.

if (internals.idleTimeSpellCheckerState !== undefined &&
    internals.idleTimeSpellCheckerState(sample.document) ===
'hot-mode-requested) {
 ...
}

[Xiaocheng, 2017/03/03 18:56:41]

Done.

+        internals.runIdleTimeSpellChecker(sample.document);
+    }
+
+    // For a test that does not create new spell check request, a synchronous
+    // verification finishes everything.
+    verificationForCurrentTest();
   });
 }
 
 add_result_callback(testObj => {
     if (!testObj.properties[kIsSpellcheckTest])
       return;
 
+    verificationForCurrentTest = null;
+
     /** @type {boolean} */
     var shouldRemoveSample = false;
     if (testObj.status === testObj.PASS) {
       if (testObj.properties[kCallback])
         testObj.properties[kCallback](testObj.sample);
       else
         shouldRemoveSample = true;
     } else {
       if (window.testRunner)
         shouldRemoveSample = true;
@@ skipping 33 matching lines @@
   return args;
 }
 
 /**
  * @param {!Sample|string} input
  * @param {function(!Document)|string} tester
  * @param {string} expectedText
  * @param {Object=} opt_args
  */
 function spellcheckTest(input, tester, expectedText, opt_args) {
-  if (window.testRunner)
-    window.testRunner.setMockSpellCheckerEnabled(true);
-
   /** @type {!Object} */
   const args = getTestArguments(opt_args);
   /** @type {!Test}  */
   const testObject = async_test(args[kTitle], args);
 
   if (spellcheckTestRunning) {
     testQueue.push({
         testObject: testObject, input: input,
         tester: tester, expectedText: expectedText});
     return;
   }
 
   invokeSpellcheckTest(testObject, input, tester, expectedText);
 }
 
+if (window.testRunner) {
+  window.testRunner.setMockSpellCheckerEnabled(true);
+  window.testRunner.setSpellCheckResolvedCallback(() => {
+    if (verificationForCurrentTest)
+      verificationForCurrentTest();
+  });
+}
+
 // Export symbols
 window.spellcheck_test = spellcheckTest;
 })();