Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2727663007: Use set_min_proto_version instead of set_min_version. (Closed)

Created:
3 years, 9 months ago by davidben
Modified:
3 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use set_min_proto_version instead of set_min_version. To align better with OpenSSL 1.1.0, BoringSSL is transitioning the APIs from SSL_CTX_set_min_version to (the longer but more upstream-compatible) SSL_CTX_set_min_proto_version. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/cbc9564f596b6bf5b6192fe7a608c95689031a64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/secure_socket_boringssl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
davidben
3 years, 9 months ago (2017-03-01 22:22:06 UTC) #2
zra
lgtm I'll go ahead and land this for you.
3 years, 9 months ago (2017-03-06 16:49:12 UTC) #3
zra
3 years, 9 months ago (2017-03-06 16:49:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cbc9564f596b6bf5b6192fe7a608c95689031a64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698