Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: pkg/analyzer/test/generated/parser_test.dart

Issue 2727663005: Fix parseAssignableSelector() tests and parse '?.' with Fasta. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/parser_test.dart
diff --git a/pkg/analyzer/test/generated/parser_test.dart b/pkg/analyzer/test/generated/parser_test.dart
index 4a26ac12896ba3b8b7fbdef790f34e994d60b40f..1c92cdf7d011ca88a35699dec10d63805c0e6c70 100644
--- a/pkg/analyzer/test/generated/parser_test.dart
+++ b/pkg/analyzer/test/generated/parser_test.dart
@@ -83,7 +83,7 @@ abstract class AbstractParserTestCase implements ParserTestHelpers {
Expression parseAssignableExpression(String code, bool primaryAllowed);
Expression parseAssignableSelector(
- String code, Expression prefix, bool optional,
+ String code, bool optional,
{bool allowConditional: true});
AwaitExpression parseAwaitExpression(String code);
@@ -4231,7 +4231,7 @@ abstract class ExpressionParserTestMixin implements AbstractParserTestCase {
}
void test_parseAssignableSelector_dot() {
- Expression expression = parseAssignableSelector('.x', null, true);
+ Expression expression = parseAssignableSelector('.x', true);
expect(expression, isNotNull);
assertNoErrors();
var propertyAccess = expression as PropertyAccess;
@@ -4240,7 +4240,7 @@ abstract class ExpressionParserTestMixin implements AbstractParserTestCase {
}
void test_parseAssignableSelector_index() {
- Expression expression = parseAssignableSelector('[x]', null, true);
+ Expression expression = parseAssignableSelector('[x]', true);
expect(expression, isNotNull);
assertNoErrors();
var indexExpression = expression as IndexExpression;
@@ -4250,8 +4250,7 @@ abstract class ExpressionParserTestMixin implements AbstractParserTestCase {
}
void test_parseAssignableSelector_none() {
- Expression expression =
- parseAssignableSelector(';', astFactory.simpleIdentifier(null), true);
+ Expression expression = parseAssignableSelector('', true);
expect(expression, isNotNull);
assertNoErrors();
var identifier = expression as SimpleIdentifier;
@@ -4259,7 +4258,7 @@ abstract class ExpressionParserTestMixin implements AbstractParserTestCase {
}
void test_parseAssignableSelector_question_dot() {
- Expression expression = parseAssignableSelector('?.x', null, true);
+ Expression expression = parseAssignableSelector('?.x', true);
expect(expression, isNotNull);
assertNoErrors();
var propertyAccess = expression as PropertyAccess;
@@ -7720,8 +7719,10 @@ class ParserTestCase extends EngineTestCase
@override
Expression parseAssignableSelector(
- String code, Expression prefix, bool optional,
+ String code, bool optional,
{bool allowConditional: true}) {
+ Expression prefix =
+ astFactory.simpleIdentifier(new StringToken(TokenType.STRING, 'foo', 0));
createParser(code);
return parser.parseAssignableSelector(prefix, optional,
allowConditional: allowConditional);
« no previous file with comments | « pkg/analyzer/test/generated/parser_fasta_test.dart ('k') | pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698