Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html

Issue 2727663003: Move task.describe to audit.define arg (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html b/third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html
index 1f3232a6030053bd66aa16723276ff1e4e82fd30..b00ada6573fdebdb9382839b186204466d3235af 100644
--- a/third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html
+++ b/third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html
@@ -16,43 +16,45 @@
let decodedAudio;
let expectedAudio;
- audit.define('test', function(task, should) {
- task.describe('Test webm decoding');
-
- let context = new AudioContext();
-
- let bufferLoader = new BufferLoader(
- context, ['webm-decode-expected.wav', 'test-webm.webm'],
- function(bufferList) {
- expectedAudio = bufferList[0];
- decodedAudio = bufferList[1];
-
- // Verify that we have the right number of channels and frames.
- should(decodedAudio.numberOfChannels, 'Number of channels')
- .beEqualTo(expectedAudio.numberOfChannels);
- should(decodedAudio.length, 'Decoded number of frames')
- .beEqualTo(expectedAudio.length);
-
- // Verify that the actual data matches the expected data very
- // closely.
- for (let c = 0; c < expectedAudio.numberOfChannels; ++c) {
- let snrdB = 10 *
- Math.log10(computeSNR(
- decodedAudio.getChannelData(c),
- expectedAudio.getChannelData(c)));
- should(snrdB, 'SNR between actual expected channel ' + c)
- .beGreaterThanOrEqualTo(109.56);
- should(decodedAudio.getChannelData(c), 'Decoded channel ' + c)
- .beCloseToArray(
- expectedAudio.getChannelData(c),
- {absoluteThreshold: 4.0234e-5});
- }
-
- task.done();
- });
-
- bufferLoader.load();
- });
+ audit.define(
+ {label: 'test', description: 'Test webm decoding'},
+ function(task, should) {
+
+ let context = new AudioContext();
+
+ let bufferLoader = new BufferLoader(
+ context, ['webm-decode-expected.wav', 'test-webm.webm'],
+ function(bufferList) {
+ expectedAudio = bufferList[0];
+ decodedAudio = bufferList[1];
+
+ // Verify that we have the right number of channels and
+ // frames.
+ should(decodedAudio.numberOfChannels, 'Number of channels')
+ .beEqualTo(expectedAudio.numberOfChannels);
+ should(decodedAudio.length, 'Decoded number of frames')
+ .beEqualTo(expectedAudio.length);
+
+ // Verify that the actual data matches the expected data very
+ // closely.
+ for (let c = 0; c < expectedAudio.numberOfChannels; ++c) {
+ let snrdB = 10 *
+ Math.log10(computeSNR(
+ decodedAudio.getChannelData(c),
+ expectedAudio.getChannelData(c)));
+ should(snrdB, 'SNR between actual expected channel ' + c)
+ .beGreaterThanOrEqualTo(109.56);
+ should(decodedAudio.getChannelData(c), 'Decoded channel ' + c)
+ .beCloseToArray(
+ expectedAudio.getChannelData(c),
+ {absoluteThreshold: 4.0234e-5});
+ }
+
+ task.done();
+ });
+
+ bufferLoader.load();
+ });
audit.run();
</script>

Powered by Google App Engine
This is Rietveld 408576698