chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc - Issue 272763002: Make code for the AutomaticProfileResetter more readabile (readability review)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc

Issue 272763002: Make code for the AutomaticProfileResetter more readabile (readability review) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc ('K') | « chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h"	5 #include "chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/bind_helpers.h"	10 #include "base/bind_helpers.h"

(...skipping 584 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
595 if (ProfileResetGlobalError::IsSupportedOnPlatform())	595 if (ProfileResetGlobalError::IsSupportedOnPlatform())

596 ExpectResetPromptState(true /active/);	596 ExpectResetPromptState(true /active/);

597 else	597 else

598 ExpectResetPromptState(false /active/);	598 ExpectResetPromptState(false /active/);

599 resetter_delegate()->DismissPrompt();	599 resetter_delegate()->DismissPrompt();

600 ExpectResetPromptState(false /active/);	600 ExpectResetPromptState(false /active/);

601 resetter_delegate()->DismissPrompt();	601 resetter_delegate()->DismissPrompt();

602 }	602 }

603	603

604 } // namespace	604 } // namespace

	605
	Peter Kasting 2014/05/28 18:46:32 Nit: Don't add a trailing blank line Nit: Don't add a trailing blank line engedy 2014/05/30 14:38:47 Done. Show quoted text On 2014/05/28 18:46:32, Peter Kasting wrote: > Nit: Don't add a trailing blank line Done.
OLD	NEW