Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc

Issue 272763002: Make code for the AutomaticProfileResetter more readabile (readability review) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Contains the implementation for AutomaticProfileResetterDelegateImpl.
Peter Kasting 2014/05/28 18:46:32 Personally, I'm skeptical that this comment adds a
engedy 2014/05/30 14:38:47 I agree, actually I have added this after quite so
6
5 #include "chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h" 7 #include "chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h"
6 8
7 #include <string> 9 #include <string>
8 10
9 #include "base/bind.h" 11 #include "base/bind.h"
10 #include "base/bind_helpers.h" 12 #include "base/bind_helpers.h"
11 #include "base/callback.h" 13 #include "base/callback.h"
12 #include "base/logging.h" 14 #include "base/logging.h"
13 #include "base/md5.h" 15 #include "base/md5.h"
14 #include "base/memory/scoped_vector.h" 16 #include "base/memory/scoped_vector.h"
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 if (difference) { 390 if (difference) {
389 old_settings_snapshot->Subtract(new_settings_snapshot); 391 old_settings_snapshot->Subtract(new_settings_snapshot);
390 std::string report = 392 std::string report =
391 SerializeSettingsReport(*old_settings_snapshot, difference); 393 SerializeSettingsReport(*old_settings_snapshot, difference);
392 SendFeedback(report); 394 SendFeedback(report);
393 } 395 }
394 } 396 }
395 content::BrowserThread::PostTask( 397 content::BrowserThread::PostTask(
396 content::BrowserThread::UI, FROM_HERE, user_callback); 398 content::BrowserThread::UI, FROM_HERE, user_callback);
397 } 399 }
400
Peter Kasting 2014/05/28 18:46:32 Nit: Don't add a trailing blank line
engedy 2014/05/30 14:38:47 Done.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698