Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h

Issue 272763002: Make code for the AutomaticProfileResetter more readabile (readability review) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
laefer 2014/05/25 21:21:58 https://engdoc.corp.google.com/eng/doc/devguide/cp
engedy 2014/05/26 18:00:46 Done.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_DELEGATE_H_
6 #define CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_DELEGATE_H_ 6 #define CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_DELEGATE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/callback_forward.h" 9 #include "base/callback_forward.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/memory/weak_ptr.h" 11 #include "base/memory/weak_ptr.h"
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 void OnBrandcodedDefaultsFetched(); 174 void OnBrandcodedDefaultsFetched();
175 175
176 // Called back by the ProfileResetter once resetting the profile settings has 176 // Called back by the ProfileResetter once resetting the profile settings has
177 // been completed. If |old_settings_snapshot| is non-NULL, will compare it to 177 // been completed. If |old_settings_snapshot| is non-NULL, will compare it to
178 // the new settings and send the differences to Google for analysis. Finally, 178 // the new settings and send the differences to Google for analysis. Finally,
179 // will post |user_callback|. 179 // will post |user_callback|.
180 void OnProfileSettingsResetCompleted( 180 void OnProfileSettingsResetCompleted(
181 const base::Closure& user_callback, 181 const base::Closure& user_callback,
182 scoped_ptr<ResettableSettingsSnapshot> old_settings_snapshot); 182 scoped_ptr<ResettableSettingsSnapshot> old_settings_snapshot);
183 183
184 Profile* profile_; 184 Profile* profile_;
laefer 2014/05/25 21:21:58 https://engdoc.corp.google.com/eng/doc/devguide/cp
engedy 2014/05/26 18:00:46 Done.
185 GlobalErrorService* global_error_service_; 185 GlobalErrorService* global_error_service_;
186 TemplateURLService* template_url_service_; 186 TemplateURLService* template_url_service_;
187 187
188 scoped_ptr<BrandcodeConfigFetcher> brandcoded_config_fetcher_; 188 scoped_ptr<BrandcodeConfigFetcher> brandcoded_config_fetcher_;
189 scoped_ptr<BrandcodedDefaultSettings> brandcoded_defaults_; 189 scoped_ptr<BrandcodedDefaultSettings> brandcoded_defaults_;
190 190
191 const ProfileResetter::ResettableFlags resettable_aspects_; 191 const ProfileResetter::ResettableFlags resettable_aspects_;
192 scoped_ptr<ProfileResetter> profile_resetter_; 192 scoped_ptr<ProfileResetter> profile_resetter_;
193 193
194 content::NotificationRegistrar registrar_; 194 content::NotificationRegistrar registrar_;
(...skipping 16 matching lines...) Expand all
211 extensions::OneShotEvent template_url_service_ready_event_; 211 extensions::OneShotEvent template_url_service_ready_event_;
212 212
213 // This event is signaled once brandcoded default settings have been fetched, 213 // This event is signaled once brandcoded default settings have been fetched,
214 // or once it has been established that this is not a branded build. 214 // or once it has been established that this is not a branded build.
215 extensions::OneShotEvent brandcoded_defaults_fetched_event_; 215 extensions::OneShotEvent brandcoded_defaults_fetched_event_;
216 216
217 DISALLOW_COPY_AND_ASSIGN(AutomaticProfileResetterDelegateImpl); 217 DISALLOW_COPY_AND_ASSIGN(AutomaticProfileResetterDelegateImpl);
218 }; 218 };
219 219
220 #endif // CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_DELEGATE_H _ 220 #endif // CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_DELEGATE_H _
221
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698