Make code for the AutomaticProfileResetter more readabile (readability review)

chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.

[laefer, 2014/05/25 21:21:58]

https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

Please add a comment.

[engedy, 2014/05/26 18:00:45]

Done, although I could not come up with anything meaningful to say here. Please
let me know if you see something that would be worth pointing out.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
@@ skipping 225 matching lines @@
   return template_url_service_->is_default_search_managed();
 }
 
 scoped_ptr<base::ListValue> AutomaticProfileResetterDelegateImpl::
     GetPrepopulatedSearchProvidersDetails() const {
   size_t default_search_index = 0;
   ScopedVector<TemplateURLData> engines(
       TemplateURLPrepopulateData::GetPrepopulatedEngines(
           profile_->GetPrefs(), &default_search_index));
   scoped_ptr<base::ListValue> engines_details_list(new base::ListValue);
   for (ScopedVector<TemplateURLData>::const_iterator it = engines.begin();

[laefer, 2014/05/25 21:21:58]

This can be rewritten more clearly as:

  for (const auto& engine : engines) {

[engedy, 2014/05/26 18:00:46]

Indeed, I could not agree more. -- However, for compatibility reasons, it is not
allowed to use C++11 constructs in the Chromium code. :(

        it != engines.end(); ++it) {
     TemplateURL template_url(profile_, **it);
     engines_details_list->Append(
         BuildSubTreeFromTemplateURL(&template_url).release());
   }
   return engines_details_list.Pass();
 }
 
 bool AutomaticProfileResetterDelegateImpl::TriggerPrompt() {
   DCHECK(global_error_service_);
@@ skipping 118 matching lines @@
     if (difference) {
       old_settings_snapshot->Subtract(new_settings_snapshot);
       std::string report =
           SerializeSettingsReport(*old_settings_snapshot, difference);
       SendFeedback(report);
     }
   }
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE, user_callback);
 }
+