Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2727583006: Timeline: fix NPE when hovering over Interactions strip (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 } 490 }
491 return element; 491 return element;
492 } 492 }
493 493
494 /** 494 /**
495 * @override 495 * @override
496 * @param {number} entryIndex 496 * @param {number} entryIndex
497 */ 497 */
498 highlightEntry(entryIndex) { 498 highlightEntry(entryIndex) {
499 SDK.DOMModel.hideDOMNodeHighlight(); 499 SDK.DOMModel.hideDOMNodeHighlight();
500 if (this._entryType(entryIndex) !== Timeline.TimelineFlameChartEntryType.Eve nt)
501 return;
500 var event = /** @type {!SDK.TracingModel.Event} */ (this._entryData[entryInd ex]); 502 var event = /** @type {!SDK.TracingModel.Event} */ (this._entryData[entryInd ex]);
501 if (!event)
502 return;
503 var target = this._model.targetByEvent(event); 503 var target = this._model.targetByEvent(event);
504 if (!target) 504 if (!target)
505 return; 505 return;
506 var timelineData = TimelineModel.TimelineData.forEvent(event); 506 var timelineData = TimelineModel.TimelineData.forEvent(event);
507 var backendNodeId = timelineData.backendNodeId; 507 var backendNodeId = timelineData.backendNodeId;
508 if (!backendNodeId) 508 if (!backendNodeId)
509 return; 509 return;
510 new SDK.DeferredDOMNode(target, backendNodeId).highlight(); 510 new SDK.DeferredDOMNode(target, backendNodeId).highlight();
511 } 511 }
512 512
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
814 * @return {boolean} 814 * @return {boolean}
815 */ 815 */
816 _isVisible(event) { 816 _isVisible(event) {
817 return this._filters.every(function(filter) { 817 return this._filters.every(function(filter) {
818 return filter.accept(event); 818 return filter.accept(event);
819 }); 819 });
820 } 820 }
821 }; 821 };
822 822
823 Timeline.TimelineFlameChartDataProvider.InstantEventVisibleDurationMs = 0.001; 823 Timeline.TimelineFlameChartDataProvider.InstantEventVisibleDurationMs = 0.001;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698