Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4339)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java

Issue 2727573004: [Android Crash Reporting] Simplify crash report upload code. (Closed)
Patch Set: Fix up a comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java
deleted file mode 100644
index 8c6b0ec5e7c3477e1e4bc326b59f2c980345d195..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java
+++ /dev/null
@@ -1,68 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.crash;
-
-import android.app.IntentService;
-import android.content.Context;
-import android.content.Intent;
-
-import org.chromium.base.Log;
-
-import java.io.File;
-import java.util.concurrent.Callable;
-
-/**
- * Service that extracts the logcat dump and saves it to a file.
- */
-public class LogcatExtractionService extends IntentService {
- private static final String TAG = "LogcatExtraction";
-
- private static final String MINIDUMP_FILENAMES = "minidump_filenames";
- private static final String REDIRECT_INTENT = "redirect_intent";
-
- public static Intent createLogcatExtractionTask(
- Context context, File[] files, Intent redirectIntent) {
- Intent intent = new Intent(context, LogcatExtractionService.class);
- String[] names = new String[files.length];
- for (int i = 0; i < files.length; ++i) {
- names[i] = files[i].getName();
- }
- intent.putExtra(MINIDUMP_FILENAMES, names);
- intent.putExtra(REDIRECT_INTENT, redirectIntent);
- return intent;
- }
-
- public LogcatExtractionService() {
- super(TAG);
- setIntentRedelivery(true);
- }
-
- private static Callable<Boolean> createLogcatExtractionServiceCallable(
- Context context, String[] filenames, Intent redirectIntent) {
- return new LogcatExtractionCallable(context, filenames, redirectIntent);
- }
-
- private void handleLogcatExtractionRequest(Intent intent) {
- String[] minidumpFileNames = intent.getStringArrayExtra(MINIDUMP_FILENAMES);
- if (minidumpFileNames == null) {
- Log.w(TAG, "Minidump filename not found. Cannot extra logcat.");
- return;
- }
-
- Intent redirectIntent = intent.getParcelableExtra(REDIRECT_INTENT);
-
- try {
- Context ctx = getApplicationContext();
- createLogcatExtractionServiceCallable(ctx, minidumpFileNames, redirectIntent).call();
- } catch (Exception e) {
- Log.w(TAG, e.toString());
- }
- }
-
- @Override
- protected void onHandleIntent(Intent intent) {
- handleLogcatExtractionRequest(intent);
- }
-}

Powered by Google App Engine
This is Rietveld 408576698