Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java

Issue 2727573004: [Android Crash Reporting] Simplify crash report upload code. (Closed)
Patch Set: Tuck up one more return stmt Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
index f0013517d8ac16f8610ea221dec67442e226f753..02e8d84c1a102825e622074ded4bca33d64e175b 100644
--- a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
@@ -45,9 +45,6 @@ public class CrashFileManager {
@VisibleForTesting
public static final String CRASH_DUMP_LOGFILE = "uploads.log";
- private static final Pattern MINIDUMP_FIRST_TRY_PATTERN =
- Pattern.compile("\\.dmp([0-9]*)$\\z");
-
private static final Pattern MINIDUMP_MIME_FIRST_TRY_PATTERN =
Pattern.compile("\\.dmp([0-9]+)$\\z");
@@ -126,10 +123,6 @@ public class CrashFileManager {
return isSuccess;
}
- public File[] getMinidumpWithoutLogcat() {
- return listCrashFiles(MINIDUMP_FIRST_TRY_PATTERN);
- }
-
public static boolean isMinidumpMIMEFirstTry(String path) {
return MINIDUMP_MIME_FIRST_TRY_PATTERN.matcher(path).find();
}

Powered by Google App Engine
This is Rietveld 408576698