Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 2727573003: gpu: Add sync token dependencies to flush metadata. (Closed)
Patch Set: use verified sync token Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation_unittest.cc
diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc
index 48484912b0d7e007bcb1b9fca45f72a5e80b9323..5e32a0605df3529e19b9e6241b3efead9499dbfe 100644
--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc
+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc
@@ -4154,10 +4154,10 @@ TEST_F(GLES2ImplementationTest, VerifySyncTokensCHROMIUM_Sequence) {
// Ensure proper sequence of checking and validating.
Sequence sequence;
- EXPECT_CALL(*gpu_control_, CanWaitUnverifiedSyncToken(Pointee(sync_token1)))
+ EXPECT_CALL(*gpu_control_, CanWaitUnverifiedSyncToken(sync_token1))
.InSequence(sequence)
.WillOnce(Return(true));
- EXPECT_CALL(*gpu_control_, CanWaitUnverifiedSyncToken(Pointee(sync_token2)))
+ EXPECT_CALL(*gpu_control_, CanWaitUnverifiedSyncToken(sync_token2))
.InSequence(sequence)
.WillOnce(Return(true));
EXPECT_CALL(*gpu_control_, EnsureWorkVisible())
@@ -4171,11 +4171,12 @@ TEST_F(GLES2ImplementationTest, VerifySyncTokensCHROMIUM_Sequence) {
}
TEST_F(GLES2ImplementationTest, WaitSyncTokenCHROMIUM) {
- const CommandBufferNamespace kNamespaceId = CommandBufferNamespace::GPU_IO;
- const CommandBufferId kCommandBufferId =
- CommandBufferId::FromUnsafeValue(234u);
- const GLuint64 kFenceSync = 456u;
- GLbyte sync_token[GL_SYNC_TOKEN_SIZE_CHROMIUM];
+ CommandBufferNamespace kNamespaceId = CommandBufferNamespace::GPU_IO;
+ CommandBufferId kCommandBufferId = CommandBufferId::FromUnsafeValue(234u);
+ GLuint64 kFenceSync = 456u;
+
+ gpu::SyncToken sync_token;
+ GLbyte* sync_token_data = sync_token.GetData();
EXPECT_CALL(*gpu_control_, IsFenceSyncRelease(kFenceSync))
.WillOnce(Return(true));
@@ -4185,7 +4186,7 @@ TEST_F(GLES2ImplementationTest, WaitSyncTokenCHROMIUM) {
EXPECT_CALL(*gpu_control_, GetCommandBufferID())
.WillOnce(Return(kCommandBufferId));
EXPECT_CALL(*gpu_control_, GetExtraCommandBufferData()).WillOnce(Return(0));
- gl_->GenSyncTokenCHROMIUM(kFenceSync, sync_token);
+ gl_->GenSyncTokenCHROMIUM(kFenceSync, sync_token_data);
struct Cmds {
cmds::WaitSyncTokenCHROMIUM wait_sync_token;
@@ -4194,7 +4195,8 @@ TEST_F(GLES2ImplementationTest, WaitSyncTokenCHROMIUM) {
expected.wait_sync_token.Init(kNamespaceId, kCommandBufferId.GetUnsafeValue(),
kFenceSync);
- gl_->WaitSyncTokenCHROMIUM(sync_token);
+ EXPECT_CALL(*gpu_control_, WaitSyncToken(sync_token));
+ gl_->WaitSyncTokenCHROMIUM(sync_token_data);
EXPECT_EQ(0, memcmp(&expected, commands_, sizeof(expected)));
}
@@ -4222,7 +4224,7 @@ TEST_F(GLES2ImplementationTest, WaitSyncTokenCHROMIUMErrors) {
ClearCommands();
gpu::SyncToken unverified_sync_token(CommandBufferNamespace::GPU_IO, 0,
gpu::CommandBufferId(), 0);
- EXPECT_CALL(*gpu_control_, CanWaitUnverifiedSyncToken(_))
+ EXPECT_CALL(*gpu_control_, CanWaitUnverifiedSyncToken(unverified_sync_token))
.WillOnce(Return(false));
gl_->WaitSyncTokenCHROMIUM(unverified_sync_token.GetConstData());
EXPECT_TRUE(NoCommandsWritten());

Powered by Google App Engine
This is Rietveld 408576698