Chromium Code Reviews| Index: gpu/command_buffer/client/gpu_control.h |
| diff --git a/gpu/command_buffer/client/gpu_control.h b/gpu/command_buffer/client/gpu_control.h |
| index 6b7bdd52b4b46fa2755cf2a62c62dcf3bccc2a8b..af8ab35617b1a19eabab3cc8f1399d77d89a01b1 100644 |
| --- a/gpu/command_buffer/client/gpu_control.h |
| +++ b/gpu/command_buffer/client/gpu_control.h |
| @@ -98,15 +98,20 @@ class GPU_EXPORT GpuControl { |
| // the lock provided by the client. |
| virtual bool IsFenceSyncReleased(uint64_t release) = 0; |
| - // Runs |callback| when sync token is signalled. |
| + // Runs |callback| when sync token is signaled. |
| virtual void SignalSyncToken(const SyncToken& sync_token, |
| const base::Closure& callback) = 0; |
| + // Returns true if the wait is valid. This is used in addition to |
|
piman
2017/03/13 23:17:39
nit: it doesn't return anything.
sunnyps
2017/03/15 00:03:08
Done.
|
| + // WaitSyncToken in the command buffer. The wait command is used to pull |
| + // texture updates from other threads when used with MailboxManagerSync. |
|
piman
2017/03/13 23:17:39
I don't think this one has anything to do with pul
sunnyps
2017/03/15 00:03:08
The comment was about why the WaitSyncToken comman
|
| + virtual void WaitSyncToken(const SyncToken& sync_token) = 0; |
| + |
| // Under some circumstances a sync token may be used which has not been |
| - // verified to have been flushed. For example, fence syncs queued on the |
| - // same channel as the wait command guarantee that the fence sync will |
| - // be enqueued first so does not need to be flushed. |
| - virtual bool CanWaitUnverifiedSyncToken(const SyncToken* sync_token) = 0; |
| + // verified to have been flushed. For example, fence syncs queued on the same |
| + // channel as the wait command guarantee that the fence sync will be enqueued |
| + // first so does not need to be flushed. |
| + virtual bool CanWaitUnverifiedSyncToken(const SyncToken& sync_token) = 0; |
| private: |
| DISALLOW_COPY_AND_ASSIGN(GpuControl); |