[sql] Convert thumbnails and top-sites databases to auto-recovery.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d78593c90b498d5868e1bf7a59b9194400f47b26..869e8a058fdbb12da88beb049168d06747496481 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -21096,6 +21096,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="History.FaviconsRecoveredPercentage" units="%">
+  <obsolete>
+    Deprecated as of March 2017.

[pwnall, 2017/03/04 01:35:32]

Can these say "Removed as of March 2017. No longer tracked." ?

[Scott Hess - ex-Googler, 2017/03/07 01:34:31]

Done, though "No longer tracked as of March 2017."

+  </obsolete>
   <owner>rpop@google.com</owner>
   <summary>
     Size of the recovered Favicons database relative to the original corrupt
@@ -21107,6 +21110,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="History.FaviconsRecoveredRowsFaviconBitmaps">
+  <obsolete>
+    Deprecated as of March 2017.
+  </obsolete>
   <owner>rpop@google.com</owner>
   <summary>
     Rows recovered from [favicon_bitmaps] table in Favicons recovery.
@@ -21114,11 +21120,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="History.FaviconsRecoveredRowsFavicons">
+  <obsolete>
+    Deprecated as of March 2017.
+  </obsolete>
   <owner>rpop@google.com</owner>
   <summary>Rows recovered from [favicons] table in Favicons recovery.</summary>
 </histogram>
 
 <histogram name="History.FaviconsRecoveredRowsIconMapping">
+  <obsolete>
+    Deprecated as of March 2017.
+  </obsolete>
   <owner>rpop@google.com</owner>
   <summary>
     Rows recovered from [icon_mapping] table in Favicons recovery.
@@ -21126,6 +21138,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="History.FaviconsRecovery" enum="HistoryFaviconsRecoveryEnum">
+  <obsolete>
+    Deprecated as of March 2017.
+  </obsolete>
   <owner>rpop@google.com</owner>
   <summary>
     Track results of SQLite database recovery code in thumbnail_database.cc.
@@ -93699,6 +93714,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 
 <enum name="HistoryFaviconsRecoveryEnum" type="int">
   <summary>Error states noted in thumbnail_database.cc recovery code.</summary>
+  <obsolete>
+    Obsolete March 2017.

[pwnall, 2017/03/04 01:35:32]

Why is this one not following the pattern above?

[Scott Hess - ex-Googler, 2017/03/07 01:34:31]

Random, I was copy-pasting from some other enum (in case the format was
different, it wasn't).  Made it regular.

+  </obsolete>
   <int value="0" label="RECOVERY_EVENT_RECOVERED">Successful recovery.</int>
   <int value="1" label="RECOVERY_EVENT_FAILED_SCOPER">
     sql::Recovery failed init.
@@ -93797,7 +93815,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="1" label="RECOVERY_EVENT_DEPRECATED">
     Recovery found deprecated version and razed.
   </int>
-  <int value="2" label="RECOVERY_EVENT_FAILED_SCOPER">
+  <int value="2" label="RECOVERY_EVENT_FAILED_SCOPER (obsolete Mar 2017)">
     sql::Recovery failed init.
   </int>
   <int value="3" label="RECOVERY_EVENT_FAILED_META_VERSION">
@@ -93806,13 +93824,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="4" label="RECOVERY_EVENT_FAILED_META_WRONG_VERSION">
     Recovery meta table has an unexpected version.
   </int>
-  <int value="5" label="RECOVERY_EVENT_FAILED_META_INIT">
+  <int value="5" label="RECOVERY_EVENT_FAILED_META_INIT (obsolete Mar 2017)">
     Failed sql::MetaTable::Init().
   </int>
-  <int value="6" label="RECOVERY_EVENT_FAILED_SCHEMA_INIT">
+  <int value="6" label="RECOVERY_EVENT_FAILED_SCHEMA_INIT (obsolete Mar 2017)">
     Failed to init target schema.
   </int>
-  <int value="7" label="RECOVERY_EVENT_FAILED_AUTORECOVER_THUMBNAILS">
+  <int value="7"
+      label="RECOVERY_EVENT_FAILED_AUTORECOVER_THUMBNAILS (obsolete Mar 2017)">
     Failed recovery on thumbnails table.
   </int>
   <int value="8" label="RECOVERY_EVENT_FAILED_COMMIT">
@@ -107793,6 +107812,10 @@ value.
     Autorecover failed setup with NOTADB, then successfully deleted the
     unrecoverable db and verified that it now works.
   </int>
+  <int value="32" label="RECOVERY_FAILED_AUTORECOVERDB_META_VERSION">
+    Autorecover failed because required version information was missing from the
+    [meta] table.
+  </int>
 </enum>
 
 <enum name="SqliteStatsEnum" type="int">