[sql] Convert thumbnails and top-sites databases to auto-recovery.

sql/recovery_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sql/recovery.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 816 matching lines @@
     ASSERT_TRUE(expecter.SawExpectedErrors());
   }
 
   // Recovery poisoned the handle, must re-open.
   db().Close();
   ASSERT_TRUE(Reopen());
 
   EXPECT_EQ("", GetSchema(&db()));
 }
 
+// Allow callers to validate the database between recovery and commit.
+TEST_F(SQLRecoveryTest, BeginRecoverDatabase) {
+  // Create a table with a broken index.
+  ASSERT_TRUE(db().Execute("CREATE TABLE t (id INTEGER PRIMARY KEY, c TEXT)"));
+  ASSERT_TRUE(db().Execute("CREATE UNIQUE INDEX t_id ON t (id)"));
+  ASSERT_TRUE(db().Execute("INSERT INTO t VALUES (1, 'hello world')"));
+  ASSERT_TRUE(db().Execute("INSERT INTO t VALUES (2, 'testing')"));
+  ASSERT_TRUE(db().Execute("INSERT INTO t VALUES (3, 'nope')"));
+
+  // Inject corruption into the index.
+  db().Close();
+  const char kDeleteSql[] = "DELETE FROM t WHERE id = 3";
+  ASSERT_TRUE(sql::test::CorruptTableOrIndex(db_path(), "t_id", kDeleteSql));
+  ASSERT_TRUE(Reopen());
+
+  // id as read from index.
+  const char kSelectIndexIdSql[] = "SELECT id FROM t INDEXED BY t_id";
+  EXPECT_EQ("1,2,3", ExecuteWithResults(&db(), kSelectIndexIdSql, "|", ","));
+
+  // id as read from table.
+  const char kSelectTableIdSql[] = "SELECT id FROM t NOT INDEXED";
+  EXPECT_EQ("1,2", ExecuteWithResults(&db(), kSelectTableIdSql, "|", ","));
+
+  // Run recovery code, then rollback.  Database remains the same.
+  {
+    std::unique_ptr<sql::Recovery> recovery =
+        sql::Recovery::BeginRecoverDatabase(&db(), db_path());
+    ASSERT_TRUE(recovery);
+    sql::Recovery::Rollback(std::move(recovery));
+  }
+  db().Close();
+  ASSERT_TRUE(Reopen());
+  EXPECT_EQ("1,2,3", ExecuteWithResults(&db(), kSelectIndexIdSql, "|", ","));
+  EXPECT_EQ("1,2", ExecuteWithResults(&db(), kSelectTableIdSql, "|", ","));
+
+  // Run recovery code, then commit.  The failing row is dropped.
+  {
+    std::unique_ptr<sql::Recovery> recovery =
+        sql::Recovery::BeginRecoverDatabase(&db(), db_path());
+    ASSERT_TRUE(recovery);
+    ASSERT_TRUE(sql::Recovery::Recovered(std::move(recovery)));
+  }
+  db().Close();
+  ASSERT_TRUE(Reopen());
+  EXPECT_EQ("1,2", ExecuteWithResults(&db(), kSelectIndexIdSql, "|", ","));
+  EXPECT_EQ("1,2", ExecuteWithResults(&db(), kSelectTableIdSql, "|", ","));
+}
+
 // Test histograms recorded when the invalid database cannot be attached.
 TEST_F(SQLRecoveryTest, AttachFailure) {
   // Create a valid database, then write junk over the header.  This should lead
   // to SQLITE_NOTADB, which will cause ATTACH to fail.
   ASSERT_TRUE(db().Execute("CREATE TABLE x (t TEXT)"));
   ASSERT_TRUE(db().Execute("INSERT INTO x VALUES ('This is a test')"));
   db().Close();
   WriteJunkToDatabase(SQLTestBase::TYPE_OVERWRITE);
 
   const char kEventHistogramName[] = "Sqlite.RecoveryEvents";
@@ skipping 86 matching lines @@
   EXPECT_NO_FATAL_FAILURE(TestPageSize(db_path(), 1024, "1024", 1024, "1024"));
 
   // Databases with no page size specified should recover with the new default
   // page size.  2k has never been the default page size.
   ASSERT_NE("2048", default_page_size);
   EXPECT_NO_FATAL_FAILURE(
       TestPageSize(db_path(), 2048, "2048", 0, default_page_size));
 }
 
 }  // namespace