[sql] Convert thumbnails and top-sites databases to auto-recovery.

components/history/core/browser/top_sites_database_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <map>
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 68 matching lines @@
 // with no data.
 TEST_F(TopSitesDatabaseTest, Version1) {
   ASSERT_TRUE(CreateDatabaseFromSQL(file_name_, "TopSites.v1.sql"));
 
   TopSitesDatabase db;
   ASSERT_TRUE(db.Init(file_name_));
   VerifyTablesAndColumns(db.db_.get());
   VerifyDatabaseEmpty(db.db_.get());
 }
 
+// Version 2 is deprecated, the resulting schema should be current,
+// with no data.
 TEST_F(TopSitesDatabaseTest, Version2) {
   ASSERT_TRUE(CreateDatabaseFromSQL(file_name_, "TopSites.v2.sql"));
 
   TopSitesDatabase db;
   ASSERT_TRUE(db.Init(file_name_));
-
   VerifyTablesAndColumns(db.db_.get());
-
-  // Basic operational check.
-  MostVisitedURLList urls;
-  std::map<GURL, Images> thumbnails;
-  db.GetPageThumbnails(&urls, &thumbnails);
-  ASSERT_EQ(3u, urls.size());
-  ASSERT_EQ(3u, thumbnails.size());
-  EXPECT_EQ(kUrl0, urls[0].url);  // [0] because of url_rank.
-  // kGoogleThumbnail includes nul terminator.
-  ASSERT_EQ(sizeof(kGoogleThumbnail) - 1,
-            thumbnails[urls[0].url].thumbnail->size());
-  EXPECT_TRUE(!memcmp(thumbnails[urls[0].url].thumbnail->front(),
-                      kGoogleThumbnail, sizeof(kGoogleThumbnail) - 1));
-
-  ASSERT_TRUE(db.RemoveURL(urls[1]));
-  db.GetPageThumbnails(&urls, &thumbnails);
-  ASSERT_EQ(2u, urls.size());
-  ASSERT_EQ(2u, thumbnails.size());
+  VerifyDatabaseEmpty(db.db_.get());
 }
 
 TEST_F(TopSitesDatabaseTest, Version3) {
   ASSERT_TRUE(CreateDatabaseFromSQL(file_name_, "TopSites.v3.sql"));
 
   TopSitesDatabase db;
   ASSERT_TRUE(db.Init(file_name_));
 
   VerifyTablesAndColumns(db.db_.get());
 
@@ skipping 67 matching lines @@
   // Database is unusable at the SQLite level.
   {
     sql::test::ScopedErrorExpecter expecter;
     expecter.ExpectError(SQLITE_CORRUPT);
     sql::Connection raw_db;
     EXPECT_TRUE(raw_db.Open(file_name_));
     EXPECT_FALSE(raw_db.IsSQLValid("PRAGMA integrity_check"));
     ASSERT_TRUE(expecter.SawExpectedErrors());
   }
 
-  // Corruption should be detected and recovered during Init().  After recovery,
-  // the Version2 checks should work.
+  // Corruption should be detected and recovered during Init().
   {
     sql::test::ScopedErrorExpecter expecter;
     expecter.ExpectError(SQLITE_CORRUPT);
 
     TopSitesDatabase db;
     ASSERT_TRUE(db.Init(file_name_));
-
     VerifyTablesAndColumns(db.db_.get());
-
-    // Basic operational check.
-    MostVisitedURLList urls;
-    std::map<GURL, Images> thumbnails;
-    db.GetPageThumbnails(&urls, &thumbnails);
-    ASSERT_EQ(3u, urls.size());
-    ASSERT_EQ(3u, thumbnails.size());
-    EXPECT_EQ(kUrl0, urls[0].url);  // [0] because of url_rank.
-    // kGoogleThumbnail includes nul terminator.
-    ASSERT_EQ(sizeof(kGoogleThumbnail) - 1,
-              thumbnails[urls[0].url].thumbnail->size());
-    EXPECT_TRUE(!memcmp(thumbnails[urls[0].url].thumbnail->front(),
-                        kGoogleThumbnail, sizeof(kGoogleThumbnail) - 1));
+    VerifyDatabaseEmpty(db.db_.get());
 
     ASSERT_TRUE(expecter.SawExpectedErrors());
   }
 }
 
 TEST_F(TopSitesDatabaseTest, Recovery3) {
   // Recovery module only supports some platforms at this time.
   if (!sql::Recovery::FullRecoverySupported())
     return;
 
@@ skipping 226 matching lines @@
   db.RemoveURL(url2);
 
   db.GetPageThumbnails(&urls, &thumbnails);
   ASSERT_EQ(4u, urls.size());
   ASSERT_EQ(4u, thumbnails.size());
   EXPECT_EQ(mapsUrl, urls[0].url);
   EXPECT_EQ(kUrl0, urls[1].url);
 }
 
 }  // namespace history