Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 272753003: During editing, merge inline style with overriding other author styles (Closed)

Created:
6 years, 7 months ago by Kyungtae Kim
Modified:
6 years, 5 months ago
CC:
blink-reviews, leviw_travelin_and_unemployed
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

During editing, merge inline style with overriding other author styles Inline styles need to override other author styles even on DoNotOverrideValues mode. So, merge and override inline styles to other author styles before merging them to m_mutableStyle. Test: editing/deleting/merge-div-with-inline-style.html Merge from WebKit: http://webkit.org/b/122874 BUG=371312 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178739

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
A LayoutTests/editing/deleting/merge-div-with-inline-style.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/editing/deleting/merge-div-with-inline-style-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Kyungtae Kim
PTAL
6 years, 7 months ago (2014-05-12 06:22:41 UTC) #1
eseidel
Yosin is your best editing reviewer.
6 years, 6 months ago (2014-05-29 00:14:18 UTC) #2
yosin_UTC9
ACK if {linux,mac,win}_blink_rel passed. It is better to put test file name in bottom as ...
6 years, 6 months ago (2014-05-29 01:18:23 UTC) #3
Yuta Kitamura
LGTM with nits. https://codereview.chromium.org/272753003/diff/1/LayoutTests/editing/deleting/merge-div-with-inline-style.html File LayoutTests/editing/deleting/merge-div-with-inline-style.html (right): https://codereview.chromium.org/272753003/diff/1/LayoutTests/editing/deleting/merge-div-with-inline-style.html#newcode19 LayoutTests/editing/deleting/merge-div-with-inline-style.html:19: + 'The test passes if "bar" ...
6 years, 6 months ago (2014-05-29 06:48:24 UTC) #4
Kyungtae Kim
The CQ bit was checked by ktf.kim@samsung.com
6 years, 5 months ago (2014-07-23 02:36:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ktf.kim@samsung.com/272753003/20001
6 years, 5 months ago (2014-07-23 02:36:42 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 07:13:37 UTC) #7
Message was sent while issue was closed.
Change committed as 178739

Powered by Google App Engine
This is Rietveld 408576698