Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3110)

Unified Diff: base/allocator/malloc_zone_functions_mac.h

Issue 2727463002: mac: Several minor fixes to allocator shim. (Closed)
Patch Set: more compile error. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/allocator/allocator_shim_unittest.cc ('k') | base/allocator/malloc_zone_functions_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/malloc_zone_functions_mac.h
diff --git a/base/allocator/malloc_zone_functions_mac.h b/base/allocator/malloc_zone_functions_mac.h
index c2ec2fcd3535fee4952a7c6a91048601fb337e54..a7f55433785fea9bb5218274fb82aaab6666ebd7 100644
--- a/base/allocator/malloc_zone_functions_mac.h
+++ b/base/allocator/malloc_zone_functions_mac.h
@@ -40,24 +40,23 @@ typedef void (*free_definite_size_type)(struct _malloc_zone_t* zone,
typedef size_t (*size_fn_type)(struct _malloc_zone_t* zone, const void* ptr);
struct MallocZoneFunctions {
- MallocZoneFunctions();
- malloc_type malloc = nullptr;
- calloc_type calloc = nullptr;
- valloc_type valloc = nullptr;
- free_type free = nullptr;
- realloc_type realloc = nullptr;
- memalign_type memalign = nullptr;
- batch_malloc_type batch_malloc = nullptr;
- batch_free_type batch_free = nullptr;
- free_definite_size_type free_definite_size = nullptr;
- size_fn_type size = nullptr;
- const ChromeMallocZone* context = nullptr;
+ malloc_type malloc;
+ calloc_type calloc;
+ valloc_type valloc;
+ free_type free;
+ realloc_type realloc;
+ memalign_type memalign;
+ batch_malloc_type batch_malloc;
+ batch_free_type batch_free;
+ free_definite_size_type free_definite_size;
+ size_fn_type size;
+ const ChromeMallocZone* context;
};
-void StoreZoneFunctions(const ChromeMallocZone* zone,
- MallocZoneFunctions* functions);
+BASE_EXPORT void StoreZoneFunctions(const ChromeMallocZone* zone,
+ MallocZoneFunctions* functions);
static constexpr int kMaxZoneCount = 30;
-BASE_EXPORT extern MallocZoneFunctions* g_malloc_zones;
+BASE_EXPORT extern MallocZoneFunctions g_malloc_zones[kMaxZoneCount];
// The array g_malloc_zones stores all information about malloc zones before
// they are shimmed. This information needs to be accessed during dispatch back
@@ -79,8 +78,13 @@ BASE_EXPORT extern MallocZoneFunctions* g_malloc_zones;
//
// Most allocations go through the default allocator. We will ensure that the
// default allocator is stored as the first MallocZoneFunctions.
-BASE_EXPORT void StoreMallocZone(ChromeMallocZone* zone);
+//
+// Returns whether the zone was successfully stored.
+BASE_EXPORT bool StoreMallocZone(ChromeMallocZone* zone);
BASE_EXPORT bool IsMallocZoneAlreadyStored(ChromeMallocZone* zone);
+BASE_EXPORT bool DoesMallocZoneNeedReplacing(
+ ChromeMallocZone* zone,
+ const MallocZoneFunctions* functions);
BASE_EXPORT int GetMallocZoneCountForTesting();
BASE_EXPORT void ClearAllMallocZonesForTesting();
« no previous file with comments | « base/allocator/allocator_shim_unittest.cc ('k') | base/allocator/malloc_zone_functions_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698