Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 272743002: Do not check GTK+ dependencies when use_ozone is defined. (Closed)

Created:
6 years, 7 months ago by joone
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not check GTK+ dependencies when use_ozone is defined. glib is not included in ozone platform: https://codereview.chromium.org/249583003 Therefore, we do not need to check GTK+ dependencies when use_ozone is defined. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/linux/system.gyp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
joone
Could you review this patch?
6 years, 7 months ago (2014-05-08 05:57:40 UTC) #1
sadrul
LGTM
6 years, 7 months ago (2014-05-08 18:16:09 UTC) #2
joone
The CQ bit was checked by joone.hur@intel.com
6 years, 7 months ago (2014-05-08 18:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joone.hur@intel.com/272743002/1
6 years, 7 months ago (2014-05-08 18:41:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 23:08:53 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 18:04:49 UTC) #6
Message was sent while issue was closed.
Change committed as 269373

Powered by Google App Engine
This is Rietveld 408576698