Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 2727343002: Calculate text ranges for default args. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index 286b2551dd644106fcef24d91c2e161e2e98c8a9..f9c6a455878a067f0be6961396d64d843b289998 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -115,7 +115,8 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
int elemOffset,
String paramName,
String paramType,
- String defaultArgListString}) {
+ String defaultArgListString,
+ List<int> defaultArgumentListTextRanges}) {
CompletionSuggestion cs =
getSuggest(completion: completion, csKind: csKind, elemKind: elemKind);
if (cs == null) {
@@ -155,6 +156,9 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
if (defaultArgListString != null) {
expect(cs.defaultArgumentListString, defaultArgListString);
}
+ if (defaultArgumentListTextRanges != null) {
+ expect(cs.defaultArgumentListTextRanges, defaultArgumentListTextRanges);
+ }
return cs;
}
@@ -204,7 +208,9 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
int elemOffset,
String defaultArgListString}) {
CompletionSuggestion cs = assertSuggest(name,
- relevance: relevance, importUri: importUri, elemOffset: elemOffset,
+ relevance: relevance,
+ importUri: importUri,
+ elemOffset: elemOffset,
defaultArgListString: defaultArgListString);
protocol.Element element = cs.element;
expect(element, isNotNull);
@@ -262,13 +268,15 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
bool isDeprecated: false,
int relevance: DART_RELEVANCE_DEFAULT,
String importUri,
- String defaultArgListString}) {
+ String defaultArgListString,
+ List<int> defaultArgumentListTextRanges}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,
importUri: importUri,
isDeprecated: isDeprecated,
- defaultArgListString: defaultArgListString);
+ defaultArgListString: defaultArgListString,
+ defaultArgumentListTextRanges: defaultArgumentListTextRanges);
if (returnType != null) {
expect(cs.returnType, returnType);
} else if (isNullExpectedReturnTypeConsideredDynamic) {
@@ -356,13 +364,15 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
String importUri,
CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
bool isDeprecated: false,
- String defaultArgListString}) {
+ String defaultArgListString,
+ List<int> defaultArgumentListTextRanges}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,
importUri: importUri,
isDeprecated: isDeprecated,
- defaultArgListString: defaultArgListString);
+ defaultArgListString: defaultArgListString,
+ defaultArgumentListTextRanges: defaultArgumentListTextRanges);
expect(cs.declaringType, equals(declaringType));
expect(cs.returnType, returnType != null ? returnType : 'dynamic');
protocol.Element element = cs.element;

Powered by Google App Engine
This is Rietveld 408576698