Add @MirrorsUsed annotations to speed up tests.

Add @MirrorsUsed annotations to speed up tests.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/46ba54e31560d9156277172015d2dfbc643d5171

[floitsch, 2017-03-02 18:49:36]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[floitsch, 2017-03-02 18:49:37]

These annotations sped up dart2js test runs from 3min30 to 3min40 on my machine.
(That's on 32 cores. I'm guessing that this will have a similar effect on the
buildbot).

[floitsch, 2017-03-07 11:17:50]

Ping.

Mistyped the times last time:
tools/test.py --mode=release -cdart2js -rd8 lib/mirrors
Before: 05:35
After: 03:42

[Siggi Cherem (dart-lang), 2017-03-07 18:51:55]

lgtm - much faster to review by patching it locally :)

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/basic_typ...
File tests/lib/mirrors/basic_types_in_dart_core_test.dart (right):

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/basic_typ...
tests/lib/mirrors/basic_types_in_dart_core_test.dart:7: @MirrorsUsed(targets:
const [#int, #double, #num, #bool, #String, #List, #Null,
maybe only specify dart.core as an entire library?

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/generic_l...
File tests/lib/mirrors/generic_list_test.dart (right):

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/generic_l...
tests/lib/mirrors/generic_list_test.dart:7: @MirrorsUsed(targets: const
["test.superclass", #List])
same here (replace with dart.core) and in other places where you explicitly call
out #List?

[Siggi Cherem (dart-lang), 2017-03-08 00:11:38]

FYI - sra@ is about to land a new test in this folder, if he lands it before you
land yours, you might want to add @MirrorsUsed there too (I believe the file
will be called function_apply_test)

[floitsch, 2017-03-08 10:44:22]

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/basic_typ...
File tests/lib/mirrors/basic_types_in_dart_core_test.dart (right):

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/basic_typ...
tests/lib/mirrors/basic_types_in_dart_core_test.dart:7: @MirrorsUsed(targets:
const [#int, #double, #num, #bool, #String, #List, #Null,
On 2017/03/07 18:51:55, Siggi Cherem (dart-lang) wrote:
> maybe only specify dart.core as an entire library?

Done.

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/generic_l...
File tests/lib/mirrors/generic_list_test.dart (right):

https://codereview.chromium.org/2727323002/diff/1/tests/lib/mirrors/generic_l...
tests/lib/mirrors/generic_list_test.dart:7: @MirrorsUsed(targets: const
["test.superclass", #List])
On 2017/03/07 18:51:55, Siggi Cherem (dart-lang) wrote:
> same here (replace with dart.core) and in other places where you explicitly
call
> out #List?

Done.

[floitsch, 2017-03-31 10:46:40]

Description was changed from

==========
Add @MirrorsUsed annotations to speed up tests.
==========

to

==========
Add @MirrorsUsed annotations to speed up tests.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/46ba54e31560d9156277172015d2dfbc643d5171
==========

[floitsch, 2017-03-31 10:46:42]

Committed patchset #3 (id:40001) manually as
46ba54e31560d9156277172015d2dfbc643d5171 (presubmit successful).