Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2727313004: Recover correctly from this-parameter on non-constructors. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Recover correctly from this-parameter on non-constructors. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/ff89087641dc0d5a3d1e1621f869b67b132654a7

Patch Set 1 #

Patch Set 2 : Update status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M pkg/front_end/lib/src/fasta/builder/procedure_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 2 chunks +0 lines, -8 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-03 11:15:44 UTC) #2
Johnni Winther
lgtm
3 years, 9 months ago (2017-03-03 11:29:12 UTC) #3
ahe
3 years, 9 months ago (2017-03-03 11:40:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ff89087641dc0d5a3d1e1621f869b67b132654a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698