Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2727253005: Move beforeunload hang timer duties to its own timer. (Closed)
Patch Set: rev Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 6749aafe832138b29352a637eb1107f508b56817..8c44414cbda911773b920c08a7dd79d3a988a60a 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4858,16 +4858,6 @@ void WebContentsImpl::RendererUnresponsive(
"ChildProcess.HangRendererType", type,
RendererUnresponsiveType::RENDERER_UNRESPONSIVE_MAX);
- RenderFrameHostImpl* rfhi =
- static_cast<RenderFrameHostImpl*>(GetRenderViewHost()->GetMainFrame());
- if (rfhi->is_waiting_for_beforeunload_ack()) {
- // If the hang is in the beforeunload handler, pretend the beforeunload
- // listeners have all fired and allow the delegate to continue closing;
- // the user will not have the option of cancelling the close.
- rfhi->SimulateBeforeUnloadAck();
- return;
- }
-
if (!GetRenderViewHost() || !GetRenderViewHost()->IsRenderViewLive())
return;

Powered by Google App Engine
This is Rietveld 408576698