Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/browser/background_fetch/background_fetch_job_controller.h

Issue 2727253002: Added DownloadItem::Observer to JobController. (Closed)
Patch Set: Added TODO Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_job_controller.h
diff --git a/content/browser/background_fetch/background_fetch_job_controller.h b/content/browser/background_fetch/background_fetch_job_controller.h
index 00d92383bb8669d166a32b90a1ffda888f67701b..b53501824990fedfd00c626eec4555497fe911c9 100644
--- a/content/browser/background_fetch/background_fetch_job_controller.h
+++ b/content/browser/background_fetch/background_fetch_job_controller.h
@@ -7,9 +7,12 @@
#include <memory>
#include <string>
+#include <unordered_map>
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "content/common/content_export.h"
+#include "content/public/browser/download_item.h"
namespace content {
@@ -21,15 +24,15 @@ class StoragePartition;
// The JobController will be responsible for coordinating communication with the
// DownloadManager. It will get requests from the JobData and dispatch them to
// the DownloadManager. It lives entirely on the IO thread.
-// TODO(harkness): The JobController should also observe downloads.
-class CONTENT_EXPORT BackgroundFetchJobController {
+class CONTENT_EXPORT BackgroundFetchJobController
+ : public DownloadItem::Observer {
public:
BackgroundFetchJobController(
const std::string& job_guid,
BrowserContext* browser_context,
StoragePartition* storage_partition,
std::unique_ptr<BackgroundFetchJobData> job_data);
- ~BackgroundFetchJobController();
+ ~BackgroundFetchJobController() override;
// Start processing on a batch of requests. Some of these may already be in
// progress or completed from a previous chromium instance.
@@ -39,10 +42,22 @@ class CONTENT_EXPORT BackgroundFetchJobController {
void Shutdown();
private:
+ // DownloadItem::Observer methods.
+ void OnDownloadUpdated(DownloadItem* item) override;
+ void OnDownloadDestroyed(DownloadItem* item) override;
+
+ // Callback passed to the DownloadManager which will be invoked once the
+ // download starts.
+ void DownloadStarted(const std::string& request_guid,
+ DownloadItem* item,
+ DownloadInterruptReason reason);
+
void ProcessRequest(const BackgroundFetchRequestInfo& request);
// Pointer to the browser context. The BackgroundFetchJobController is owned
// by the BrowserContext via the StoragePartition.
+ // TODO(harkness): Currently this is only used to lookup the DownloadManager.
+ // Investigate whether the DownloadManager should be passed instead.
BrowserContext* browser_context_;
// Pointer to the storage partition. This object is owned by the partition
@@ -52,6 +67,11 @@ class CONTENT_EXPORT BackgroundFetchJobController {
// The JobData which talks to the DataManager for this job_guid.
std::unique_ptr<BackgroundFetchJobData> job_data_;
+ // Map from the GUID assigned by the DownloadManager to the request_guid.
+ std::unordered_map<std::string, std::string> download_guid_map_;
+
+ base::WeakPtrFactory<BackgroundFetchJobController> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(BackgroundFetchJobController);
};

Powered by Google App Engine
This is Rietveld 408576698