Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2727233005: Remove calls to styleForLayoutObject() in LayoutTreeBuilder::style() (Closed)
Patch Set: Format issue Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.h
diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h
index 21a3f70b0e3cfc4b39c469440a7b8c21d8573c49..e9b02ed115b5925ff190f8e0db6f81f62c08efee 100644
--- a/third_party/WebKit/Source/core/dom/Element.h
+++ b/third_party/WebKit/Source/core/dom/Element.h
@@ -418,6 +418,7 @@ class CORE_EXPORT Element : public ContainerNode {
virtual bool layoutObjectIsNeeded(const ComputedStyle&);
void recalcStyle(StyleRecalcChange, Text* nextTextSibling = nullptr);
void rebuildLayoutTree();
+ void recalcStyleForReattach();
void pseudoStateChanged(CSSSelector::PseudoType);
void setAnimationStyleChange(bool);
void clearAnimationStyleChange();
@@ -799,6 +800,8 @@ class CORE_EXPORT Element : public ContainerNode {
// TODO(tkent): Rename this to isFocusableStyle.
virtual bool layoutObjectIsFocusable() const;
+ virtual bool childrenCanHaveStyle() const { return true; }
+
// classAttributeChanged() exists to share code between
// parseAttribute (called via setAttribute()) and
// svgAttributeChanged (called when element.className.baseValue is set)
@@ -849,6 +852,10 @@ class CORE_EXPORT Element : public ContainerNode {
StyleRecalcChange recalcOwnStyle(StyleRecalcChange, Text*);
void reattachPseudoElementLayoutTree(PseudoId);
void rebuildShadowRootLayoutTree();
+ void recalcOwnStyleForReattach();
+ void recalcContainedStyleForReattach();
+ void recalcShadowRootStylesForReattach();
+ void recalcPseudoStyleForReattach(PseudoId);
inline void checkForEmptyStyleChange();
void updatePseudoElement(PseudoId, StyleRecalcChange);

Powered by Google App Engine
This is Rietveld 408576698