third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 2727233004: Timeline: fix NPE in heavy stack view when clearing Timeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2727233004: Timeline: fix NPE in heavy stack view when clearing Timeline (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index abe08608bb0a12947bda95e4b27e60e83af0e133..75c98695af596f75a623d706490c995b2f7eab2b 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -240,8 +240,10 @@ Timeline.TimelineTreeView = class extends UI.VBox {

if (this._searchableView)

this._searchableView.cancelSearch();

this._dataGrid.rootNode().removeChildren();

- if (!this._model)

+ if (!this._model) {

+ this._updateDetailsForSelection();

return;

+ }

this._root = this._buildTree();

var children = this._root.children();

var maxSelfTime = 0;

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js ('k') | no next file » | no next file with comments »