chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h - Issue 2727233003: Uses child views in Autofill Popup so we can trigger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)

Patch Set: Removes base/optional.h include and inline definitions. Uses NSInteger instead of int. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc » ('j') | chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

diff --git a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

index 78081db9331f8f7a15fe57ed5d2e70be68c5250d..47a2d77d8f69f7ae0057c5eb131b0ba69f9dcc9e 100644

--- a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

+++ b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

@@ -50,8 +50,9 @@ class AutofillKeyboardAccessoryView : public AutofillPopupView {

// AutofillPopupView implementation.

void Show() override;

void Hide() override;

- void InvalidateRow(size_t row) override;

- void UpdateBoundsAndRedrawPopup() override;

+ void OnSelectedRowChanged(base::Optional<int> previous_row_selection,

+ base::Optional<int> current_row_selection) override;

+ void OnSuggestionsChanged() override;

private:

~AutofillKeyboardAccessoryView() override;