chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm - Issue 2727233003: Uses child views in Autofill Popup so we can trigger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)

Patch Set: Uses base::Optional<size_t> instead of representing no selection as -1. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

index e95bea9dbb9910071305acea2af39d3c9a7c0df9..75c9345e4b58ad7cfb0b2a51dc6a170462554047 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

@@ -126,7 +126,8 @@ using autofill::AutofillPopupLayoutModel;

NSString* value = SysUTF16ToNSString(controller_->GetElidedValueAt(i));

NSString* label = SysUTF16ToNSString(controller_->GetElidedLabelAt(i));

- BOOL isSelected = static_cast<int>(i) == controller_->selected_line();

+ BOOL isSelected = controller_->selected_line() &&

+ i == controller_->selected_line().value();

[self drawSuggestionWithName:value

subtext:label

index:i