Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7728)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)
Patch Set: Uses base::Optional<size_t> instead of representing no selection as -1. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
index e4503946ef0790e0532fcfd44f9e9f0f717ea72e..dc323fb146246919714c1da4006e4dc5b7f120e7 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
@@ -49,7 +49,7 @@ void AutofillPopupViewAndroid::Show() {
env, view, reinterpret_cast<intptr_t>(this),
view_android->GetWindowAndroid()->GetJavaObject()));
- UpdateBoundsAndRedrawPopup();
+ OnSuggestionsChanged();
}
void AutofillPopupViewAndroid::Hide() {
@@ -63,7 +63,7 @@ void AutofillPopupViewAndroid::Hide() {
}
}
-void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
+void AutofillPopupViewAndroid::OnSuggestionsChanged() {
if (java_object_.is_null())
return;
@@ -170,8 +170,6 @@ void AutofillPopupViewAndroid::PopupDismissed(
delete this;
}
-void AutofillPopupViewAndroid::InvalidateRow(size_t) {}
-
// static
bool AutofillPopupViewAndroid::RegisterAutofillPopupViewAndroid(JNIEnv* env) {
return RegisterNativesImpl(env);

Powered by Google App Engine
This is Rietveld 408576698