Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5789)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_view.h

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)
Patch Set: Combines 2 calls to InvalidateRow to 1 OnSelectedRowChanged call. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_view.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_view.h b/chrome/browser/ui/autofill/autofill_popup_view.h
index 4bb752fe467bf8df3249916f09268fbc35640c29..ec4e533098340efdd290af3905e71397786eee7f 100644
--- a/chrome/browser/ui/autofill/autofill_popup_view.h
+++ b/chrome/browser/ui/autofill/autofill_popup_view.h
@@ -9,6 +9,7 @@
#include "base/strings/string16.h"
#include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h"
+#include "ui/accessibility/ax_enums.h"
namespace autofill {
@@ -18,17 +19,22 @@ class AutofillPopupController;
// AutofillPopupView.
class AutofillPopupView {
public:
+ static constexpr int kNoSelection = -1;
+
// Displays the Autofill popup and fills it in with data from the controller.
virtual void Show() = 0;
// Hides the popup from view. This will cause the popup to be deleted.
virtual void Hide() = 0;
- // Invalidates the given row and redraw it.
- virtual void InvalidateRow(size_t row) = 0;
+ // Invalidates the given rows and redraws them. A value of |kNoSelection| for
+ // either parameter indicates the parameter does not correspond to a
+ // suggestion.
+ virtual void OnSelectedRowChanged(size_t previous_row_selection,
+ size_t current_row_selection) = 0;
- // Refreshes the position of the popup.
- virtual void UpdateBoundsAndRedrawPopup() = 0;
+ // Refreshes the position and redraws popup when suggestions change.
+ virtual void OnSuggestionsChanged() = 0;
// Factory function for creating the view.
static AutofillPopupView* Create(AutofillPopupController* controller);

Powered by Google App Engine
This is Rietveld 408576698