chrome/browser/ui/views/autofill/autofill_popup_view_views.h - Issue 2727233003: Uses child views in Autofill Popup so we can trigger

Unified Diff: chrome/browser/ui/views/autofill/autofill_popup_view_views.h

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)

Patch Set: Adds test coverage for changing number of suggestions. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/autofill/autofill_popup_view_views.h

diff --git a/chrome/browser/ui/views/autofill/autofill_popup_view_views.h b/chrome/browser/ui/views/autofill/autofill_popup_view_views.h

index 01f214b2e1f05b4604a48e686c7252c46741ea07..d26fa5a1cf3b9fbc68d2b1c7a761fc4ee95dd3b2 100644

--- a/chrome/browser/ui/views/autofill/autofill_popup_view_views.h

+++ b/chrome/browser/ui/views/autofill/autofill_popup_view_views.h

@@ -19,25 +19,32 @@ class AutofillPopupController;

class AutofillPopupViewViews : public AutofillPopupBaseView,

public AutofillPopupView {

public:

+ // |controller| should not be null.

AutofillPopupViewViews(AutofillPopupController* controller,

views::Widget* parent_widget);

- private:

~AutofillPopupViewViews() override;

+ private:

+ FRIEND_TEST_ALL_PREFIXES(AutofillPopupViewViewsTest,

+ NotifyAccessibilityEventForRow);

// AutofillPopupView implementation.

void Show() override;

void Hide() override;

void InvalidateRow(size_t row) override;

void UpdateBoundsAndRedrawPopup() override;

Evan Stade 2017/03/06 21:45:33 probably better to change this to a more generic n

csashi 2017/03/07 01:53:53 Done.

+ void NotifyAccessibilityEventForRow(ui::AXEvent event_type,

+ size_t row) override;

// views::Views implementation

void OnPaint(gfx::Canvas* canvas) override;

+ void GetAccessibleNodeData(ui::AXNodeData* node_data) override;

// Draw the given autofill entry in |entry_rect|.

void DrawAutofillEntry(gfx::Canvas* canvas,

int index,

const gfx::Rect& entry_rect);

+ // Creates one child view for every suggestion.

Evan Stade 2017/03/06 21:45:33 nit: newline before this line. Also a more informa

csashi 2017/03/07 01:53:53 Done.

+ void CreateChildViews();

AutofillPopupController* controller_; // Weak reference.