Uses child views in Autofill Popup so we can trigger

chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h"
 
 #include "base/logging.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
@@ skipping 10 matching lines @@
   view_.reset([[AutofillPopupViewCocoa alloc] initWithController:controller
                                                            frame:NSZeroRect
                                                         delegate:this]);
 }
 
 AutofillPopupViewBridge::~AutofillPopupViewBridge() {
   [view_ controllerDestroyed];
   [view_ hidePopup];
 }
 
-gfx::Rect AutofillPopupViewBridge::GetRowBounds(size_t index) {
+gfx::Rect AutofillPopupViewBridge::GetRowBounds(int index) {
   return controller_->layout_model().GetRowBounds(index);
 }
 
 int AutofillPopupViewBridge::GetIconResourceID(
     const base::string16& resource_name) {
   return controller_->layout_model().GetIconResourceID(resource_name);
 }
 
 void AutofillPopupViewBridge::Hide() {
   delete this;
 }
 
 void AutofillPopupViewBridge::Show() {
   [view_ showPopup];
 }
 
-void AutofillPopupViewBridge::InvalidateRow(size_t row) {
-  [view_ invalidateRow:row];
+void AutofillPopupViewBridge::OnSelectedRowChanged(

[groby-ooo-7-16, 2017/03/20 20:42:55]

The docs[1] suggest not using Optional<> as a function parameter.

[1] https://chromium.googlesource.com/chromium/src/+/master/docs/optional.md

[Evan Stade, 2017/03/20 21:36:57]

I asked for this. See discussion above.

Cocoa will want to send an a11y event which it does not currently do.

[Evan Stade, 2017/03/20 21:41:05]

also, I think that those docs need to be updated. base::Optional has good
ergonomics --- you can base base::nullopt or you can pass a value and it
implicitly makes an Optional.

[csashi, 2017/03/20 21:41:51]

Discussed in https://codereview.chromium.org/2727233003/#msg71. Would be useful
if we have a strict guideline, one way or another.

[groby-ooo-7-16, 2017/03/20 22:53:10]

Fine with it for this CL. Would love it if you could raise the general issue on
cr-dev. 

[Evan Stade, 2017/03/20 22:57:30]

The docs and impl were written by mlamouri so I sent him a CL/question.

[groby-ooo-7-16, 2017/03/20 22:58:42]

Thank you!

+    base::Optional<int> previous_row_selection,
+    base::Optional<int> current_row_selection) {
+  if (previous_row_selection) {
+    [view_ invalidateRow:*previous_row_selection];
+  }
+
+  if (current_row_selection) {
+    [view_ invalidateRow:*current_row_selection];
+  }
 }
 
-void AutofillPopupViewBridge::UpdateBoundsAndRedrawPopup() {
+void AutofillPopupViewBridge::OnSuggestionsChanged() {
   [view_ updateBoundsAndRedrawPopup];
 }
 
 AutofillPopupView* AutofillPopupView::Create(
     AutofillPopupController* controller) {
   return new AutofillPopupViewBridge(controller);
 }
 
 }  // namespace autofill