Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/ui/views/autofill/autofill_popup_view_views.h

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)
Patch Set: Uses base::Optional<size_t> instead of representing no selection as -1. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/optional.h"
11 #include "chrome/browser/ui/autofill/autofill_popup_view.h" 12 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
12 #include "chrome/browser/ui/views/autofill/autofill_popup_base_view.h" 13 #include "chrome/browser/ui/views/autofill/autofill_popup_base_view.h"
13 14
14 namespace autofill { 15 namespace autofill {
15 16
16 class AutofillPopupController; 17 class AutofillPopupController;
17 18
18 // Views toolkit implementation for AutofillPopupView. 19 // Views toolkit implementation for AutofillPopupView.
19 class AutofillPopupViewViews : public AutofillPopupBaseView, 20 class AutofillPopupViewViews : public AutofillPopupBaseView,
20 public AutofillPopupView { 21 public AutofillPopupView {
21 public: 22 public:
23 // |controller| should not be null.
22 AutofillPopupViewViews(AutofillPopupController* controller, 24 AutofillPopupViewViews(AutofillPopupController* controller,
23 views::Widget* parent_widget); 25 views::Widget* parent_widget);
26 ~AutofillPopupViewViews() override;
24 27
25 private: 28 private:
26 ~AutofillPopupViewViews() override; 29 FRIEND_TEST_ALL_PREFIXES(AutofillPopupViewViewsTest, OnSelectedRowChanged);
27 30
28 // AutofillPopupView implementation. 31 // AutofillPopupView implementation.
29 void Show() override; 32 void Show() override;
30 void Hide() override; 33 void Hide() override;
31 void InvalidateRow(size_t row) override; 34 void OnSelectedRowChanged(
32 void UpdateBoundsAndRedrawPopup() override; 35 base::Optional<size_t> previous_row_selection,
36 base::Optional<size_t> current_row_selection) override;
37 void OnSuggestionsChanged() override;
33 38
34 // views::Views implementation 39 // views::Views implementation
35 void OnPaint(gfx::Canvas* canvas) override; 40 void OnPaint(gfx::Canvas* canvas) override;
41 void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
36 42
37 // Draw the given autofill entry in |entry_rect|. 43 // Draw the given autofill entry in |entry_rect|.
38 void DrawAutofillEntry(gfx::Canvas* canvas, 44 void DrawAutofillEntry(gfx::Canvas* canvas,
39 int index, 45 int index,
40 const gfx::Rect& entry_rect); 46 const gfx::Rect& entry_rect);
41 47
48 // Creates child views based on the suggestions given by |controller_|. These
49 // child views are used for accessibility events only. We need child views to
50 // populate the correct |AXNodeData| when user selects a suggestion.
51 void CreateChildViews();
52
42 AutofillPopupController* controller_; // Weak reference. 53 AutofillPopupController* controller_; // Weak reference.
43 54
44 DISALLOW_COPY_AND_ASSIGN(AutofillPopupViewViews); 55 DISALLOW_COPY_AND_ASSIGN(AutofillPopupViewViews);
45 }; 56 };
46 57
47 } // namespace autofill 58 } // namespace autofill
48 59
49 #endif // CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_ 60 #endif // CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698