Issue 272723007: Add timing to dump_record.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 272723007: Add timing to dump_record. (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
f(malita), mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add timing to dump_record. Prints microsecond timing for each command in the left-hand column: optimized flat/http___mobile_news_sandbox_google_com_news_pt0_scroll_layer_7.skp 4.0 1 Save 2075.0 2 DrawRect 104.0 3 BoundedDrawPosTextH 135.4 4 DrawRect 9.4 5 DrawRect 5.6 6 DrawRect 8.2 7 DrawRect 6.8 8 DrawRect ... (I'm sure Rietveld will just mangle the crap out of that. It's helpfully right-aligned.) To do this, I made Draw from SkRecordDraw Skia-public as SkRecords::Draw, and time it command-by-command. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14672

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -71 lines)			Patch
M	gyp/tools.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/record/SkRecordDraw.h	View		1 chunk	+37 lines, -1 line	0 comments	Download
M	src/record/SkRecordDraw.cpp	View		2 chunks	+19 lines, -47 lines	0 comments	Download
M	tools/dump_record.cpp	View	1 2 3	4 chunks	+56 lines, -23 lines	0 comments	Download