Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2727223002: Round the subpixel accumulation used for composited scrolling content (Closed)
Patch Set: Round the subpixel accumulation in PaintLayerPainter for scrolling contents. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-fractional-offset-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
index 8aa1b45ddc3d32f32fa3d49a291bd3182cd6b108..680abaf07b2155e308a4b506162bc0684258ad91 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
@@ -325,6 +325,10 @@ PaintResult PaintLayerPainter::paintLayerContents(
m_paintLayer.compositingState() == PaintsIntoOwnBacking
? m_paintLayer.subpixelAccumulation()
: paintingInfoArg.subPixelAccumulation;
+ // The composited scrolling contents layer position rounds the subpixel
+ // accumulation.
+ if (isPaintingScrollingContent)
+ subpixelAccumulation = LayoutSize(roundedIntSize(subpixelAccumulation));
flackr 2017/03/14 21:07:19 I found where we seem to first make the incorrect
ShouldRespectOverflowClipType respectOverflowClip =
shouldRespectOverflowClip(paintFlags, m_paintLayer.layoutObject());
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-fractional-offset-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698